https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/97352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/97352
>From b67ecd20cc2c11f4f99c2d90c95fdbd988659947 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Wed, 26 Jun 2024 12:31:39 -0700
Subject: [PATCH 1/6] [HLSL] Implement `export` keyword
Fixes #92812
---
.../clang/
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/97352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -129,6 +129,55 @@ class MyClass
}
};
+// Exported function without body - not used
+export void exportedFunctionUnused(float f);
hekota wrote:
Also adding test for this here: https://github.com/llvm/llvm-project/pull/97370
https://github.com/llvm/llvm-p
@@ -129,6 +129,55 @@ class MyClass
}
};
+// Exported function without body - not used
+export void exportedFunctionUnused(float f);
hekota wrote:
Done.
https://github.com/llvm/llvm-project/pull/97352
___
cfe-comm
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/97352
>From b67ecd20cc2c11f4f99c2d90c95fdbd988659947 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Wed, 26 Jun 2024 12:31:39 -0700
Subject: [PATCH 1/6] [HLSL] Implement `export` keyword
Fixes #92812
---
.../clang/
@@ -129,6 +129,55 @@ class MyClass
}
};
+// Exported function without body - not used
+export void exportedFunctionUnused(float f);
hekota wrote:
Good catch! This is currently not reporting an error and the redeclaration is
not recognized as exported funct
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/97352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -129,6 +129,55 @@ class MyClass
}
};
+// Exported function without body - not used
+export void exportedFunctionUnused(float f);
python3kgae wrote:
Will there be an error if has export when declare like
```
export void export_mismatch(float f);
```
But w
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/97352
>From b67ecd20cc2c11f4f99c2d90c95fdbd988659947 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Wed, 26 Jun 2024 12:31:39 -0700
Subject: [PATCH 1/5] [HLSL] Implement `export` keyword
Fixes #92812
---
.../clang/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 938cbdb4cf428bf08558c24d845aeac9174c7022
c8c6b5084bd1bb5f01d3e4edd2d8c932ff9ea0ad --
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97352
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Helena Kotas (hekota)
Changes
Implements availability diagnostic on `export` functions.
For shader libraries the HLSL availability diagnostic should run on all entry
points and export functions. Now that the `export` keyword is implemente
https://github.com/hekota created
https://github.com/llvm/llvm-project/pull/97352
Implements availability diagnostic on `export` functions.
For shader libraries the HLSL availability diagnostic should run on all entry
points and export functions. Now that the `export` keyword is implemented,
14 matches
Mail list logo
