[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/72139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/72139 >From 8be56542f25b08ee5d6a325f76d12c28c4a366d7 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 13 Nov 2023 11:14:06 -0600 Subject: [PATCH 1/4] [HLSL] Parameter modifier parsing and AST This change im

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/72139 >From 8be56542f25b08ee5d6a325f76d12c28c4a366d7 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 13 Nov 2023 11:14:06 -0600 Subject: [PATCH 1/3] [HLSL] Parameter modifier parsing and AST This change im

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/72139 >From 8be56542f25b08ee5d6a325f76d12c28c4a366d7 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 13 Nov 2023 11:14:06 -0600 Subject: [PATCH 1/2] [HLSL] Parameter modifier parsing and AST This change im

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/72139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/72139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

@@ -0,0 +1,64 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.6-library %s -verify +void fn(in out float f); // #fn + +// expected-error@#fn2{{duplicate parameter modifier 'in'}} +// expected-note@#fn2{{conflicting attribute is here}} +void fn2(in in float f); // #fn2 + +// ex

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

@@ -5559,7 +5562,6 @@ bool Parser::isTypeSpecifierQualifier() { case tok::kw___read_write: case tok::kw___write_only: case tok::kw___funcref: - case tok::kw_groupshared: return true; bogner wrote: This is technically an unrelated bugfix. Not sure i

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/python3kgae approved this pull request. Maybe a verify test for use rvalue for inout parameter. https://github.com/llvm/llvm-project/pull/72139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/72139 >From 8be56542f25b08ee5d6a325f76d12c28c4a366d7 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 13 Nov 2023 11:14:06 -0600 Subject: [PATCH] [HLSL] Parameter modifier parsing and AST This change implem

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0e42df4031e8b2fec357e07ca5ca3b81adf0b5ad b99d291f99805bc090b8e51b8f8ad176a7cdd642 --

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Chris B (llvm-beanz) Changes This change implements parsing for HLSL's parameter modifier keywords `in`, `out` and `inout`. Because HLSL doesn't support references or pointers, these keywords are used to allow parameters to be passed in a

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/72139 This change implements parsing for HLSL's parameter modifier keywords `in`, `out` and `inout`. Because HLSL doesn't support references or pointers, these keywords are used to allow parameters to be passed in