[clang] [HLSL] Constant buffer layout struct update (PR #124840)

https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/124840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

hekota wrote: All of these changes except one are related to layout structs. I will update the PR description to make it clearer and move that one unrelated change about synthetizing initializers to the constant buffer codegen PR. https://github.com/llvm/llvm-project/pull/124840 __

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

@@ -14183,6 +14183,13 @@ void Sema::ActOnUninitializedDecl(Decl *RealDecl) { if (getLangOpts().OpenCL && Var->getType().getAddressSpace() == LangAS::opencl_local) return; + +// In HLSL, objects in the hlsl_constat address space are initialized +// exte

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/124840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

https://github.com/bogner approved this pull request. This all looks reasonable, though it is kind of a mess of random fixes. It's generally best to commit unrelated things individually, and it would be nice to have commit messages that are full sentences of what and why rather than a bulleted

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/124840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/124840 >From 63c465b40512ad4c5fff84c0b2b022b49d46eaa7 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Tue, 28 Jan 2025 13:20:30 -0800 Subject: [PATCH 1/2] [HLSL] Constant buffer layout struct update - create structs

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Helena Kotas (hekota) Changes - create structs with public fields instead of classes with private fields - add Packed attribute to prevent struct padding - use `__cblayout_` prefix in name - filter out arrays of resources (bug fix) - don't

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

https://github.com/hekota ready_for_review https://github.com/llvm/llvm-project/pull/124840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

@@ -27,6 +27,3 @@ cbuffer A { // AST-NEXT: TextComment {{.*}} Text=" CBuffer decl." // AST-NEXT: VarDecl {{.*}} a 'hlsl_constant float' // AST-NEXT: VarDecl {{.*}} b 'hlsl_constant int' -// AST-NEXT: CXXRecordDecl {{.*}} implicit class __layout_A definition -// AST: FieldDecl {

[clang] [HLSL] Constant buffer layout struct update (PR #124840)

https://github.com/hekota created https://github.com/llvm/llvm-project/pull/124840 - create structs with public fields instead of classes with private fields - add Packed attribute to prevent struct padding - use `__cblayout_` prefix in name - filter out arrays of resources (bug fix) - don't cre