https://github.com/llvm-beanz closed
https://github.com/llvm/llvm-project/pull/108035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-beanz wrote:
> looks fine. Curious, why is this extra RUN: line added? Doesn't the other one
> already contain the same parameters `-ast-dump -o - %s | FileCheck %s` ?
>
> RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -ast-dump -o - %s |
> FileCheck %s
The diff is a bit awkward
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/108035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp approved this pull request.
looks fine. Curious, why is this extra RUN: line added? Doesn't the other one
already contain the same parameters `-ast-dump -o - %s | FileCheck %s` ?
RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -ast-dump -o - %s |
FileCheck %s
llvm-beanz wrote:
> Can we test this?
It is tested. The modified test case adds a run line with `-std=hlsl202x` which
fails without this change due to narrowing conversion in an initializer list.
https://github.com/llvm/llvm-project/pull/108035
___
c
bogner wrote:
Can we test this?
https://github.com/llvm/llvm-project/pull/108035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits