[clang] [HLSL] Allow narrowing in initialization lists (PR #108035)

2024-09-12 Thread Chris B via cfe-commits
https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/108035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Allow narrowing in initialization lists (PR #108035)

2024-09-12 Thread Chris B via cfe-commits
llvm-beanz wrote: > looks fine. Curious, why is this extra RUN: line added? Doesn't the other one > already contain the same parameters `-ast-dump -o - %s | FileCheck %s` ? > > RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -ast-dump -o - %s | > FileCheck %s The diff is a bit awkward

[clang] [HLSL] Allow narrowing in initialization lists (PR #108035)

2024-09-12 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/108035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Allow narrowing in initialization lists (PR #108035)

2024-09-12 Thread Cooper Partin via cfe-commits
https://github.com/coopp approved this pull request. looks fine. Curious, why is this extra RUN: line added? Doesn't the other one already contain the same parameters `-ast-dump -o - %s | FileCheck %s` ? RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -ast-dump -o - %s | FileCheck %s

[clang] [HLSL] Allow narrowing in initialization lists (PR #108035)

2024-09-12 Thread Chris B via cfe-commits
llvm-beanz wrote: > Can we test this? It is tested. The modified test case adds a run line with `-std=hlsl202x` which fails without this change due to narrowing conversion in an initializer list. https://github.com/llvm/llvm-project/pull/108035 ___ c

[clang] [HLSL] Allow narrowing in initialization lists (PR #108035)

2024-09-10 Thread Justin Bogner via cfe-commits
bogner wrote: Can we test this? https://github.com/llvm/llvm-project/pull/108035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits