Keenuts wrote:
Hi, I don't think there is an issue with only emitting the `__spirv__` macro
with HLSL. Sent out https://github.com/llvm/llvm-project/pull/142401
https://github.com/llvm/llvm-project/pull/132848
___
cfe-commits mailing list
cfe-commits@
AaronBallman wrote:
Hi! I'm wondering why this macro needs to be exposed outside of HLSL given that
there's already `__SPIRV__` exposed for this exact purpose. These changes turn
out to be disruptive in a downstream SYCL implementation
(https://github.com/intel/llvm/issues/18219) because of a
https://github.com/s-perron closed
https://github.com/llvm/llvm-project/pull/132848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s-perron approved this pull request.
This is useful because to will match the DXC behaviour, and make code more
easier to port. Even if we have `__SPIRV__` is to good to have `__spirv__`.
https://github.com/llvm/llvm-project/pull/132848
___
https://github.com/farzonl approved this pull request.
https://github.com/llvm/llvm-project/pull/132848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cassiebeckley updated
https://github.com/llvm/llvm-project/pull/132848
>From 959f0374df39a97d22740ae81d132bed300159ea Mon Sep 17 00:00:00 2001
From: Cassandra Beckley
Date: Mon, 24 Mar 2025 17:36:46 -0700
Subject: [PATCH 1/2] [HLSL] Add __spirv__ macro
This macro can be used
https://github.com/s-perron commented:
Thanks. I was thinking of adding this myself, but it was pushed off. I don't
know the best place to put it. I'll let others who know the FE review.
https://github.com/llvm/llvm-project/pull/132848
___
cfe-commits
