https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dankm wrote:
If this looks good to people, is anyone able to merge it? I cannot do it myself.
https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
dankm wrote:
> If I understand correctly this means in effect `-stdlib=` becomes a
> don't-care when linking C, and anyhow it already had no effect.
That's correct. It was previously a harmless warning at link time, and is now
(with this change) completely ignored.
https://github.com/llvm/llv
emaste wrote:
> It handles both cases. It simply claims all the -stdlib= arguments.
If I understand correctly this means in effect `-stdlib=` becomes a don't-care
when linking C, and anyhow it already had no effect.
https://github.com/llvm/llvm-project/pull/68011
__
dankm wrote:
You do bring up an interesting point, though. When linking C code with this
change, for both Gnu and FreeBSD, `-stdlib=libbad` is ignored for C and raises
an error for C++.
Also for reference, the toolchains that ignore the stdlib argument for C are:
baremetal, Darwin, Fuchsia, G
dankm wrote:
> Does this only affect cases where one passes `-stdlib=libc++`? What happens
> if somebody passes `-stdlib=libstdc++`?
It handles both cases. It simply claims all the `-stdlib=` arguments. This is
the same behaviour as the Gnu driver used by Linux, but seems to diverge from
Darw
DimitryAndric wrote:
Does this only affect cases where one passes `-stdlib=libc++`? What happens if
somebody passes `-stdlib=libstdc++`?
https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
emaste wrote:
Yeah, I don't see any reason there'd be a problem with this. It seems a bit
silly for build systems to pass this in, but if they do there's no value in
reporting it.
https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailin
https://github.com/emaste approved this pull request.
https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dankm wrote:
> The Darwin toolchain also does this. This change LGTM, although I'm not an
> expert in FreeBSD.
Thanks. I think I'd like some FreeBSD folks to take a look. I wonder if it's
rude to @ mention a few... maybe I will.
The ones I can think of immediately are @DimitryAndric, @emaste,
https://github.com/egorzhdan approved this pull request.
The Darwin toolchain also does this. This change LGTM, although I'm not an
expert in FreeBSD.
https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/68011
>From bde5fc6394df80e598835f01d2ab8c0c186a9d5b Mon Sep 17 00:00:00 2001
From: Dan McGregor
Date: Tue, 25 Jul 2023 18:46:50 -0600
Subject: [PATCH] [Driver] Silence stdlib warning when linking C
Similar to the Gnu to
https://github.com/dankm edited https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dankm wrote:
This fixes this inconsistency:
Linux:
```
$ clang -o test -stdlib=libc++ test.c
$ ./test
Hello world
```
FreeBSD:
```
$ clang -o test -stdlib=libc++ test.c
clang: warning: argument unused during compilation: '-stdlib=libc++'
[-Wunused-command-line-argument]
$ ./test
Hello world
``
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Similar to the Gnu toolchain, ignore uses of '-stdlib=libc++' when linking C
code. CMake insists on adding it to the command line when linking C, and a
bunch of other build systems to similarly.
---
Full diff: https://github.com/llvm/llvm
https://github.com/dankm created https://github.com/llvm/llvm-project/pull/68011
Similar to the Gnu toolchain, ignore uses of '-stdlib=libc++' when linking C
code. CMake insists on adding it to the command line when linking C, and a
bunch of other build systems to similarly.
>From 70d76223501e
16 matches
Mail list logo
