[clang] [Clang] suggest headers on undeclared errors (PR #140247)

https://github.com/jongmyeong-choi closed https://github.com/llvm/llvm-project/pull/140247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

jongmyeong-choi wrote: I see it now. It's a good topic. I think we need to make more structural decisions and do a lot of pre-work to do this item. For now, let's close this change and discuss it in #139855. https://github.com/llvm/llvm-project/pull/140247 _

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

cor3ntin wrote: @jongmyeong-choi did you see that discussion here? https://github.com/llvm/llvm-project/issues/139855 There might be useful ideas https://github.com/llvm/llvm-project/pull/140247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

jongmyeong-choi wrote: Thanks for all your reviews. I learned a lot from your comments. I'll try to rewrite it from scratch, but honestly, it'll take me a while to figure out the TableGen structure. If anyone wants to make a change to this topic, please feel free to jump in. https://github.co

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

cor3ntin wrote: We already do have some typo correction https://compiler-explorer.com/z/Ede9rzsn5 I would expect the feature to be plugged into the same place such that: - If we find a name that is an exact match through lookup - Otherwise, if there is a name that matches exactly (respecting na

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

@@ -14,6 +14,8 @@ #include "clang/Basic/DiagnosticParse.h" #include "clang/Parse/Parser.h" #include "clang/Sema/ParsedTemplate.h" +#include "clang/Tooling/Inclusions/StandardLibrary.h" cor3ntin wrote: Sure, but we want to rewrite anyway. The implementation (St

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

@@ -14,6 +14,8 @@ #include "clang/Basic/DiagnosticParse.h" #include "clang/Parse/Parser.h" #include "clang/Sema/ParsedTemplate.h" +#include "clang/Tooling/Inclusions/StandardLibrary.h" AaronBallman wrote: This seems like a layering violation, though not a circ

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

tbaederr wrote: I can only review this on a high level, so CC @AaronBallman to check if this is happening at the right level. https://github.com/llvm/llvm-project/pull/140247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

https://github.com/jongmyeong-choi edited https://github.com/llvm/llvm-project/pull/140247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits