[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-04 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/3457 Here is the relevant piece of the b

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-04 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-04 Thread via cfe-commits
@@ -5443,11 +5443,24 @@ struct EnsureImmediateInvocationInDefaultArgs // Rewrite to source location to refer to the context in which they are used. ExprResult TransformSourceLocExpr(SourceLocExpr *E) { -if (E->getParentContext() == SemaRef.CurContext) +DeclContext

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Shafik Yaghmour via cfe-commits
@@ -5443,11 +5443,24 @@ struct EnsureImmediateInvocationInDefaultArgs // Rewrite to source location to refer to the context in which they are used. ExprResult TransformSourceLocExpr(SourceLocExpr *E) { -if (E->getParentContext() == SemaRef.CurContext) +DeclContext

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Aaron Ballman via cfe-commits
@@ -5443,11 +5443,24 @@ struct EnsureImmediateInvocationInDefaultArgs // Rewrite to source location to refer to the context in which they are used. ExprResult TransformSourceLocExpr(SourceLocExpr *E) { -if (E->getParentContext() == SemaRef.CurContext) +DeclContext

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Aaron Ballman via cfe-commits
@@ -5443,11 +5443,24 @@ struct EnsureImmediateInvocationInDefaultArgs // Rewrite to source location to refer to the context in which they are used. ExprResult TransformSourceLocExpr(SourceLocExpr *E) { -if (E->getParentContext() == SemaRef.CurContext) +DeclContext

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM with some minor grammatical nits in a comment. https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-03 Thread via cfe-commits
cor3ntin wrote: @AaronBallman btw, backporting that would be nice... https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-01 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/106925 >From 6544062d2543c86a3701a035e6e18f12a87b3ffd Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 2 Sep 2024 00:22:40 +0200 Subject: [PATCH] [Clang] Workaround dependent source location issues In #78436

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-01 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-01 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Does it fix #80210? https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-01 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/106925 >From b561f0634c08a8cc845f8a58985c67b0e7ca35ad Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 2 Sep 2024 00:22:40 +0200 Subject: [PATCH] [Clang] Workaround dependent source location issues In #78436

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes In #78436 we made some SourceLocExpr dependent to deal with the fact that their value should reflect the name of specialized function - rather than the rtemplate in which they are first used. However SourceLocE

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-01 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/106925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Workaround dependent source location issues (PR #106925)

2024-09-01 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/106925 In #78436 we made some SourceLocExpr dependent to deal with the fact that their value should reflect the name of specialized function - rather than the rtemplate in which they are first used. However SourceLoc