[clang] [Clang] Verify data layout consistency (PR #144720)

2025-07-01 Thread Nikita Popov via cfe-commits
nikic wrote: I've put up https://github.com/llvm/llvm-project/pull/146494 for the wasm f128 alignment. https://github.com/llvm/llvm-project/pull/144720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-07-01 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/144720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-07-01 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/144720 >From af31642573b26c0f987b89148b65854ea2f5919a Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Wed, 18 Jun 2025 14:48:19 +0200 Subject: [PATCH 1/2] [Clang] Verify data layout consistency Verify that the alignme

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-06-27 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM I see you opened a PR for m68k and aix; did you open a PR or issue report for wasm? https://github.com/llvm/llvm-project/pull/144720 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-06-27 Thread Nikita Popov via cfe-commits
nikic wrote: Ping :) https://github.com/llvm/llvm-project/pull/144720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-06-27 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/144720 >From 4a70541ed734969f0db13c6fdf76c79702cc2b6e Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Wed, 18 Jun 2025 14:48:19 +0200 Subject: [PATCH] [Clang] Verify data layout consistency Verify that the alignments

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-06-19 Thread Nikita Popov via cfe-commits
nikic wrote: @rjmccall From a Clang perspective, largely no -- but not entirely. There are cases when LLVM materializes allocations based on the data layout in ways that are observable and not controllable by Clang. One of these is certain inline asm constraints (which can end up passing const

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-06-18 Thread John McCall via cfe-commits
rjmccall wrote: So, devil's advocate: do we actually care about IR data layout alignments? Clang should be putting explicit alignments on everything in the IR. And, I mean, I can certainly imagine that a target might end up in an impossible situation for terrible historical reasons, because e.

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikita Popov (nikic) Changes Verify that the alignments specified by clang TargetInfo match the alignments specified by LLVM data layout, which will hopefully prevent accidental mismatches in the future. This currently contains opt-outs

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-06-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Nikita Popov (nikic) Changes Verify that the alignments specified by clang TargetInfo match the alignments specified by LLVM data layout, which will hopefully prevent accidental mismatches in the future. This currently contains o

[clang] [Clang] Verify data layout consistency (PR #144720)

2025-06-18 Thread Nikita Popov via cfe-commits
https://github.com/nikic created https://github.com/llvm/llvm-project/pull/144720 Verify that the alignments specified by clang TargetInfo match the alignments specified by LLVM data layout, which will hopefully prevent accidental mismatches in the future. This currently contains opt-outs for