https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/99038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/99038
>From fbc9ebb3900e69f2485111cfdc6b7a7dfd3e6ebe Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 16 Jul 2024 14:53:30 +0200
Subject: [PATCH 1/2] [Clang] Remove __is_nullptr
---
clang/docs/LanguageExt
@@ -447,9 +447,9 @@ Decl *Parser::ParseLinkage(ParsingDeclSpec &DS,
DeclaratorContext Context) {
///
/// HLSL: Parse export function declaration.
///
-/// export-function-declaration:
+/// export-function-declaration:
/// 'export' function-declaration
-///
@@ -117,7 +121,7 @@ Improvements to Clang's diagnostics
- Some template related diagnostics have been improved.
.. code-block:: c++
-
+
AaronBallman wrote:
Spurious whitespace change.
https://github.com/llvm/llvm-project/pull/99038
https://github.com/AaronBallman approved this pull request.
LGTM (modulo whitespace nits), but please make sure the 19.x branch gets a
release note officially deprecating the trait and saying it will be removed in
Clang 20.
https://github.com/llvm/llvm-project/pull/99038
__
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/99038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/99038
>From fbc9ebb3900e69f2485111cfdc6b7a7dfd3e6ebe Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 16 Jul 2024 14:53:30 +0200
Subject: [PATCH 1/2] [Clang] Remove __is_nullptr
---
clang/docs/LanguageExt
philnik777 wrote:
> I mostly support the removal but I'd feel more comfortable documenting the
> extension as deprecated in Clang 19, adding a release note warning users
> about it going away and what the replacement code would look like, and then
> remove `__is_nullptr()` in Clang 20. (edited
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/99038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
I mostly support the removal but I'd feel more comfortable documenting the
extension as deprecated in Clang 18, adding a release note warning users about
it going away and what the replacement code would look like, and then remove
`__is_nullptr()` in
cor3ntin wrote:
It's probably reasonable to do that, however to be on the safe side, let's
merge that after the Clang 19 branch.
It will need a release note too,
Thanks!
https://github.com/llvm/llvm-project/pull/99038
___
cfe-commits mailing list
cf
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Nikolas Klauser (philnik777)
Changes
`is_null_pointer` can be implemented very efficiently as
`__is_same(__remove_cv(T), decltype(nullptr))`. Since GCC supports both of
these builtins as well, libc++ has no interest in using `__is_nullptr
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/99038
`is_null_pointer` can be implemented very efficiently as
`__is_same(__remove_cv(T), decltype(nullptr))`. Since GCC supports both of
these builtins as well, libc++ has no interest in using `__is_nullptr` inste
13 matches
Mail list logo
