github-actions[bot] wrote:
@vortex73 Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vortex73 updated
https://github.com/llvm/llvm-project/pull/98965
>From 60a51d9150fa3f31c3eab89e1f1da3b30d190b48 Mon Sep 17 00:00:00 2001
From: Vortex
Date: Tue, 16 Jul 2024 03:01:14 +0530
Subject: [PATCH 1/6] [Clang] Refactor uses of in SemaOverload.cpp
---
clang/lib/Sema/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 87ca6386f9389f9d929d660e37701590092cefab
ef007ca0c0119298767bbc9f1a345969fe6e8c03 --e
vortex73 wrote:
@shafik I've made the changes. Please merge as I do not have write access.
https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
https://github.com/vortex73 updated
https://github.com/llvm/llvm-project/pull/98965
>From 60a51d9150fa3f31c3eab89e1f1da3b30d190b48 Mon Sep 17 00:00:00 2001
From: Vortex
Date: Tue, 16 Jul 2024 03:01:14 +0530
Subject: [PATCH 1/5] [Clang] Refactor uses of in SemaOverload.cpp
---
clang/lib/Sema/
https://github.com/vortex73 updated
https://github.com/llvm/llvm-project/pull/98965
>From 60a51d9150fa3f31c3eab89e1f1da3b30d190b48 Mon Sep 17 00:00:00 2001
From: Vortex
Date: Tue, 16 Jul 2024 03:01:14 +0530
Subject: [PATCH 1/4] [Clang] Refactor uses of in SemaOverload.cpp
---
clang/lib/Sema/
@@ -11846,19 +11854,21 @@ static void DiagnoseFailedEnableIfAttr(Sema &S,
OverloadCandidate *Cand) {
}
static void DiagnoseFailedExplicitSpec(Sema &S, OverloadCandidate *Cand) {
- ExplicitSpecifier ES = ExplicitSpecifier::getFromDecl(Cand->Function);
+ assert(Cand->Function
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -9994,8 +9995,9 @@
Sema::AddArgumentDependentLookupCandidates(DeclarationName Name,
CandEnd = CandidateSet.end();
Cand != CandEnd; ++Cand)
if (Cand->Function) {
- Fns.erase(Cand->Function);
- if (FunctionTemplateDecl *
https://github.com/shafik approved this pull request.
Thank you for this refactor, just a couple of minor comments but otherwise
looks good. Please fix first and then merge after it passes tests, if you need
someone to merge for you please let me know.
https://github.com/llvm/llvm-project/pull
@@ -11846,19 +11854,21 @@ static void DiagnoseFailedEnableIfAttr(Sema &S,
OverloadCandidate *Cand) {
}
static void DiagnoseFailedExplicitSpec(Sema &S, OverloadCandidate *Cand) {
- ExplicitSpecifier ES = ExplicitSpecifier::getFromDecl(Cand->Function);
+ assert(Cand->Function
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vortex73 wrote:
@haberman Please review.
https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vortex73 edited
https://github.com/llvm/llvm-project/pull/98965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
17 matches
Mail list logo
