https://github.com/smanna12 closed
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smanna12 wrote:
> My concerns are resolved, sorry for holding this!
No worries. Thank you
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
smanna12 wrote:
Thank you everyone for reviews.
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Fznamznon approved this pull request.
My concerns are resolved, sorry for holding this!
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -627,7 +627,7 @@ class Analyzer {
IsNoexcept = isNoexcept(FD);
} else if (auto *BD = dyn_cast(D)) {
if (auto *TSI = BD->getSignatureAsWritten()) {
-auto *FPT = TSI->getType()->getAs();
+auto *FPT = TSI->getType()->castAs();
@@ -627,7 +627,7 @@ class Analyzer {
IsNoexcept = isNoexcept(FD);
} else if (auto *BD = dyn_cast(D)) {
if (auto *TSI = BD->getSignatureAsWritten()) {
-auto *FPT = TSI->getType()->getAs();
+auto *FPT = TSI->getType()->castAs();
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/117176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -627,7 +627,7 @@ class Analyzer {
IsNoexcept = isNoexcept(FD);
} else if (auto *BD = dyn_cast(D)) {
if (auto *TSI = BD->getSignatureAsWritten()) {
-auto *FPT = TSI->getType()->getAs();
+auto *FPT = TSI->getType()->castAs();
@@ -627,7 +627,7 @@ class Analyzer {
IsNoexcept = isNoexcept(FD);
} else if (auto *BD = dyn_cast(D)) {
if (auto *TSI = BD->getSignatureAsWritten()) {
-auto *FPT = TSI->getType()->getAs();
+auto *FPT = TSI->getType()->castAs();
@@ -627,7 +627,7 @@ class Analyzer {
IsNoexcept = isNoexcept(FD);
} else if (auto *BD = dyn_cast(D)) {
if (auto *TSI = BD->getSignatureAsWritten()) {
-auto *FPT = TSI->getType()->getAs();
+auto *FPT = TSI->getType()->castAs();
@@ -627,7 +627,7 @@ class Analyzer {
IsNoexcept = isNoexcept(FD);
} else if (auto *BD = dyn_cast(D)) {
if (auto *TSI = BD->getSignatureAsWritten()) {
-auto *FPT = TSI->getType()->getAs();
+auto *FPT = TSI->getType()->castAs();
@@ -627,7 +627,7 @@ class Analyzer {
IsNoexcept = isNoexcept(FD);
} else if (auto *BD = dyn_cast(D)) {
if (auto *TSI = BD->getSignatureAsWritten()) {
-auto *FPT = TSI->getType()->getAs();
+auto *FPT = TSI->getType()->castAs();
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
This commit addresses several null pointer issues identified by static analysis
by replacing dyn_cast<> with cast<> and getAs<> with
castAs<> in various parts of the Clang codebase. The cast and castAs
method is u
@@ -1908,9 +1908,9 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
return true;
// ensure both args have 3 elements
int NumElementsArg1 =
-TheCall->getArg(0)->getType()->getAs()->getNumElements();
+TheCall->getA
https://github.com/smanna12 updated
https://github.com/llvm/llvm-project/pull/117176
>From 1b6b411291b4d7cfd830d43609eaddc65b0f2c56 Mon Sep 17 00:00:00 2001
From: "Manna, Soumi"
Date: Thu, 21 Nov 2024 07:25:11 -0800
Subject: [PATCH 1/2] [Clang] Prevent potential null pointer dereferences
---
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: None (smanna12)
Changes
This commit addresses several null pointer issues identified by static analysis
by replacing dyn_cast<> with cast<> and getAs<> with
castAs<> in various parts of the Clang codebase. The cast and castAs
method is us
@@ -1908,9 +1908,9 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
return true;
// ensure both args have 3 elements
int NumElementsArg1 =
-TheCall->getArg(0)->getType()->getAs()->getNumElements();
+TheCall->getA
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/117176
This commit addresses several null pointer issues identified by static analysis
by replacing dyn_cast<> with cast<> and getAs<> with castAs<> in various parts
of the Clang codebase. The cast and castAs method
19 matches
Mail list logo
