https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/91933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/91933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 approved this pull request.
Thanks for the prompt fix! I think this looks good now, but please wait for
@erichkeane for the final stamp.
https://github.com/llvm/llvm-project/pull/91933
___
cfe-commits mailing list
cfe-commit
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/91933
>From 4cadff527e02ae03aa5850ee713fe57aee663a52 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 13 May 2024 10:00:19 +0200
Subject: [PATCH 1/6] [Clang] Fix dependency computation for pack indexing
expre
@@ -9806,7 +9806,7 @@ QualType Sema::BuildCountAttributedArrayType(QualType
WrappedTy,
/// that expression, according to the rules in C++11
/// [dcl.type.simple]p4 and C++11 [expr.lambda.prim]p18.
QualType Sema::getDecltypeForExpr(Expr *E) {
- if (E->isTypeDependent())
+ if
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/91933
>From 4cadff527e02ae03aa5850ee713fe57aee663a52 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 13 May 2024 10:00:19 +0200
Subject: [PATCH 1/5] [Clang] Fix dependency computation for pack indexing
expre
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/91933
>From 4cadff527e02ae03aa5850ee713fe57aee663a52 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 13 May 2024 10:00:19 +0200
Subject: [PATCH 1/4] [Clang] Fix dependency computation for pack indexing
expre
@@ -377,7 +377,7 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
if (D & ExprDependence::Value)
-D |= ExprDependence::TypeInstantiat
@@ -377,7 +377,7 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
if (D & ExprDependence::Value)
-D |= ExprDependence::TypeInstantiat
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/91933
>From 4cadff527e02ae03aa5850ee713fe57aee663a52 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 13 May 2024 10:00:19 +0200
Subject: [PATCH 1/3] [Clang] Fix dependency computation for pack indexing
expre
@@ -377,7 +377,7 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
if (D & ExprDependence::Value)
-D |= ExprDependence::TypeInstantiat
@@ -377,7 +377,7 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
if (D & ExprDependence::Value)
-D |= ExprDependence::TypeInstantiat
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/91933
>From 4cadff527e02ae03aa5850ee713fe57aee663a52 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 13 May 2024 10:00:19 +0200
Subject: [PATCH 1/2] [Clang] Fix dependency computation for pack indexing
expre
@@ -376,6 +376,9 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
+ if (D & ExprDependence::Value)
+D |= ExprDependence::TypeInstanti
@@ -376,6 +376,9 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
+ if (D & ExprDependence::Value)
+D |= ExprDependence::TypeInstanti
@@ -376,6 +376,9 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
+ if (D & ExprDependence::Value)
+D |= ExprDependence::TypeInstanti
@@ -376,6 +376,9 @@ ExprDependence clang::computeDependence(PackExpansionExpr
*E) {
ExprDependence clang::computeDependence(PackIndexingExpr *E) {
ExprDependence D = E->getIndexExpr()->getDependence();
+ if (D & ExprDependence::Value)
+D |= ExprDependence::TypeInstanti
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/91933
>From 4cadff527e02ae03aa5850ee713fe57aee663a52 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon, 13 May 2024 10:00:19 +0200
Subject: [PATCH] [Clang] Fix dependency computation for pack indexing
expressio
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
Given `foo...[idx]` if idx is value dependent, the expression is type dependent.
Fixes #91885
Fixes #91884
---
Full diff: https://github.com/llvm/llvm-project/pull/91933.diff
2 Files Affected:
- (modified) c
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/91933
Given `foo...[idx]` if idx is value dependent, the expression is type dependent.
Fixes #91885
Fixes #91884
>From 066e23de6ef0b3bb44513c1d239981e7d0f4453e Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Mon
20 matches
Mail list logo
