[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

snarang181 wrote: Closing in favor of https://github.com/llvm/llvm-project/pull/144161 https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 closed https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/143722 >From 6f787e1997f53968e23586b4eb03c45e6559ebbf Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Mon, 2 Jun 2025 19:30:39 -0400 Subject: [PATCH 1/2] Add std layout diagnostics Add diagnostic test cases ---

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

snarang181 wrote: Something broke while resolving merge conflicts. Getting it back to a steady state and will mark it ready for review again. Apologies. https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 converted_to_draft https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/143722 >From e96c9c940bbfaf9da752c3537ea8bd023b8b15aa Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Mon, 2 Jun 2025 19:30:39 -0400 Subject: [PATCH 1/2] Add std layout diagnostics Add diagnostic test cases ---

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

@@ -488,3 +488,83 @@ static_assert(__is_trivially_copyable(S12)); // expected-note@-1 {{'S12' is not trivially copyable}} \ // expected-note@#tc-S12 {{'S12' defined here}} } + +namespace standard_layout_tests { +struct WithVirtual { // #sl-Virtual + virtual void foo(); +};

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/143722 >From b92f63bcd8b9910278102353bed4db6b433629ce Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Mon, 2 Jun 2025 19:30:39 -0400 Subject: [PATCH 1/2] Add std layout diagnostics Add diagnostic test cases ---

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

@@ -488,3 +488,83 @@ static_assert(__is_trivially_copyable(S12)); // expected-note@-1 {{'S12' is not trivially copyable}} \ // expected-note@#tc-S12 {{'S12' defined here}} } + +namespace standard_layout_tests { +struct WithVirtual { // #sl-Virtual + virtual void foo(); +};

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

snarang181 wrote: > Thanks a lot for working on that. > > Can you add tests for all of these examples? > https://eel.is/c++draft/class.prop#11 > > In particular > > * If there are multiple direct base classes, a type is not a standard layout > * If in the inheritance hierarchy, there are mult

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 updated https://github.com/llvm/llvm-project/pull/143722 >From 6b33849afd6c6c252eae76c4c5b17e25495ec90b Mon Sep 17 00:00:00 2001 From: Samarth Narang Date: Mon, 2 Jun 2025 19:30:39 -0400 Subject: [PATCH] Add std layout diagnostics Add diagnostic test cases --- ..

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

cor3ntin wrote: Thanks a lot for working on that. Can you add tests for all of these examples? https://eel.is/c++draft/class.prop#11 In particular - If there are multiple direct base classes, a type is not a standard layout - If in the inheritance hierarchy, there are multiple classes with m

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 edited https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

snarang181 wrote: @cor3ntin, requesting your review here. https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Samarth Narang (snarang181) Changes As part of the effort in https://github.com/llvm/llvm-project/issues/141911 --- Full diff: https://github.com/llvm/llvm-project/pull/143722.diff 4 Files Affected: - (modified) clang/include/clang/Basi

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 ready_for_review https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Explain why is_standard_layout evaluated to false (PR #143722)

https://github.com/snarang181 edited https://github.com/llvm/llvm-project/pull/143722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits