[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-12 Thread Shafik Yaghmour via cfe-commits
shafik wrote: I don't think the build error is related to this change. https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-12 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for this fix! https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/1610 Here is the relevant piece of the build log for

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread Chuanqi Xu via cfe-commits
@@ -226,6 +226,7 @@ def err_module_map_not_found : Error<"module map file '%0' not found">, def err_missing_module_name : Error< "no module name provided; specify one with -fmodule-name=">, DefaultFatal; +def err_file_is_not_module : Error<"file '%0' is not a module">, Def

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread Dmitriy Chestnykh via cfe-commits
@@ -226,6 +226,7 @@ def err_module_map_not_found : Error<"module map file '%0' not found">, def err_missing_module_name : Error< "no module name provided; specify one with -fmodule-name=">, DefaultFatal; +def err_file_is_not_module : Error<"file '%0' is not a module">, Def

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread Dmitriy Chestnykh via cfe-commits
@@ -226,6 +226,7 @@ def err_module_map_not_found : Error<"module map file '%0' not found">, def err_missing_module_name : Error< "no module name provided; specify one with -fmodule-name=">, DefaultFatal; +def err_file_is_not_module : Error<"file '%0' is not a module">, Def

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread Dmitriy Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/98439 >From 716e8b7b71422b5850d2f9c3710a28bcf18ffccb Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Thu, 11 Jul 2024 09:55:55 +0300 Subject: [PATCH 1/3] [Clang] Don't crash if input file is not a module. Curr

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread Chuanqi Xu via cfe-commits
@@ -226,6 +226,7 @@ def err_module_map_not_found : Error<"module map file '%0' not found">, def err_missing_module_name : Error< "no module name provided; specify one with -fmodule-name=">, DefaultFatal; +def err_file_is_not_module : Error<"file '%0' is not a module">, Def

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-11 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dcf70e16684420ae211dad58dbfacc0430409ab4 716e8b7b71422b5850d2f9c3710a28bcf18ffccb --e

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-10 Thread Dmitriy Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/98439 >From 716e8b7b71422b5850d2f9c3710a28bcf18ffccb Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Thu, 11 Jul 2024 09:55:55 +0300 Subject: [PATCH 1/2] [Clang] Don't crash if input file is not a module. Curr

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-10 Thread Dmitriy Chestnykh via cfe-commits
chestnykh wrote: CC: @ChuanqiXu9 @shafik https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dmitriy Chestnykh (chestnykh) Changes Currently clang crashes with `-module-file-info` and input file which is not a module Emit error instead of segfaulting. Fix #98365 --- Full diff: https://github.com/llvm/llvm-project/pull/98439.diff

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

2024-07-10 Thread Dmitriy Chestnykh via cfe-commits
https://github.com/chestnykh created https://github.com/llvm/llvm-project/pull/98439 Currently clang crashes with `-module-file-info` and input file which is not a module Emit error instead of segfaulting. Fix #98365 >From 716e8b7b71422b5850d2f9c3710a28bcf18ffccb Mon Sep 17 00:00:00 2001 From: