[clang] [Clang] Allow diagnostics starting with Arm (PR #98091)

2024-07-13 Thread via cfe-commits
https://github.com/amilendra closed https://github.com/llvm/llvm-project/pull/98091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow diagnostics starting with Arm (PR #98091)

2024-07-13 Thread via cfe-commits
amilendra wrote: > This one looks fairly benign, and while I agree that it is good to upstream > things wherever possible, my slight objection rests mostly on two principles: > > * In general the community doesn't take behavior-changing patches purely > on the basis of eliminating merge co

[clang] [Clang] Allow diagnostics starting with Arm (PR #98091)

2024-07-12 Thread Jon Roelofs via cfe-commits
jroelofs wrote: This one looks fairly benign, and while I agree that it is good to upstream things wherever possible, my slight objection rests mostly on two principles: * In general the community doesn't take behavior-changing patches purely on the basis of eliminating merge conflicts for cod

[clang] [Clang] Allow diagnostics starting with Arm (PR #98091)

2024-07-12 Thread via cfe-commits
amilendra wrote: > > If the diagnostics are downstream-only, does this really need go upstream? > > We try to upstream as much as possible to reduce merge conflicts. @jroelofs Do you have any objections to commiting this? https://github.com/llvm/llvm-project/pull/98091 ___

[clang] [Clang] Allow diagnostics starting with Arm (PR #98091)

2024-07-08 Thread Jon Roelofs via cfe-commits
jroelofs wrote: If the diagnostics are downstream-only, does this really need go upstream? https://github.com/llvm/llvm-project/pull/98091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [Clang] Allow diagnostics starting with Arm (PR #98091)

2024-07-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (amilendra) Changes We (Arm) have a few downstream-only diagnostics that start with Arm, so wish to add Arm to the list of allowed start words. --- Full diff: https://github.com/llvm/llvm-project/pull/98091.diff 1 Files Affected:

[clang] [Clang] Allow diagnostics starting with Arm (PR #98091)

2024-07-08 Thread via cfe-commits
https://github.com/amilendra created https://github.com/llvm/llvm-project/pull/98091 We (Arm) have a few downstream-only diagnostics that start with Arm, so wish to add Arm to the list of allowed start words. >From f7b07c66341f7ea0fec83d1f72d20b4bdf0bf585 Mon Sep 17 00:00:00 2001 From: Amilend