[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -427,42 +423,53 @@ class ParentMapContext::ParentMap::ASTVisitor return Result; } - bool TraverseDecl(Decl *DeclNode) { + bool TraverseDecl(Decl *DeclNode) override { return TraverseNode( -DeclNode, DeclNode, [&] { return VisitorBase::TraverseDecl(DeclN

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -427,42 +423,53 @@ class ParentMapContext::ParentMap::ASTVisitor return Result; } - bool TraverseDecl(Decl *DeclNode) { + bool TraverseDecl(Decl *DeclNode) override { return TraverseNode( -DeclNode, DeclNode, [&] { return VisitorBase::TraverseDecl(DeclN

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { Sirraide wrote: > One thing I think we'd be better off doing if we cared to make this change > (rather than cop

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { erichkeane wrote: Urgh, yeah... our const correctness with the recursive AST visitor is... bad. One thing I th

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { cor3ntin wrote: @AaronBallman @erichkeane https://github.com/llvm/llvm-project/pull/116823 ___

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { Sirraide wrote: > How hard do you think it would be to introduce something like > `MutableDynamicRecursiveASTVi

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { cor3ntin wrote: This makes sense but it is not amazing. How hard do you think it would be to introduce something

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { Sirraide wrote: So `RecursiveASTVisitor` passes everything around by non-`const` pointer, and `DynamicRecursive

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { cor3ntin wrote: Why are we removing const here (and other places)? https://github.com/llvm/llvm-project/pull/11

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/116823 >From 2b29d679a6c232387bd7e307ff579f9271222c1c Mon Sep 17 00:00:00 2001 From: Sirraide Date: Tue, 19 Nov 2024 13:28:10 +0100 Subject: [PATCH 1/4] [Clang] [NFC] Migrate visitors in AST --- clang/lib/AST/ASTImp

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/116823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits