https://github.com/jcsxky closed https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From 9e7ba80350e56f5dab87f7fc247744d8cd129c9e Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/docs/ReleaseN
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From 707c471617b91b12914a10e3763e8d78aab9c112 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/docs/ReleaseN
jcsxky wrote:
> There seems to be an issue with the rebasing of the PR. As we branch clang
> 18, the new changelog (for 19) being empty is expected
I try to merge this PR and found `ReleaseNotes.rst` is changed because of
clang-19 initialize. I don't know where should I add the release note.
cor3ntin wrote:
There seems to be an issue with the rebasing of the PR.
As we branch clang 18, the new changelog (for 19) being empty is expected
https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From 2d6a39f5d679d2a29f606a49f07c596855f2d9d0 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/docs/ReleaseN
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From 0e74e6cc4d33e4edcf7400525d1134cb7318eabc Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/docs/ReleaseN
@@ -6124,7 +6124,11 @@ QualType
TreeTransform::TransformFunctionProtoType(
// "pointer to cv-qualifier-seq X" between the optional cv-qualifer-seq
// and the end of the function-definition, member-declarator, or
// declarator.
- Sema::CXXThisScopeR
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From 5da8d470b84cc175a3be9c00314b01a1c9f78837 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/docs/ReleaseN
@@ -6124,7 +6124,11 @@ QualType
TreeTransform::TransformFunctionProtoType(
// "pointer to cv-qualifier-seq X" between the optional cv-qualifer-seq
// and the end of the function-definition, member-declarator, or
// declarator.
- Sema::CXXThisScopeR
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
https://github.com/AaronBallman commented:
Please be sure to add a release note about the fix to
clang/docs/ReleaseNotes.rst.
https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From b0fcd3b278cf625845c192301e0d9c37af09c239 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/include/clang
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
https://github.com/AaronBallman approved this pull request.
LGTM but please wait in case @erichkeane has final thoughts.
https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From 7632f631ec949f91d2ecec2b6f16951f9288920f Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/include/clang
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
@@ -7081,10 +7085,10 @@ QualType
TreeTransform::TransformAttributedType(
// FIXME: dependent operand expressions?
if (getDerived().AlwaysRebuild() ||
modifiedType != oldType->getModifiedType()) {
-// TODO: this is really lame; we should really be rebuilding the
-
@@ -0,0 +1,17 @@
+// RUN: %clang_cc1 %s -verify -fsyntax-only
+
+// expected-no-diagnostics
+
+template
+struct Bar {
+int* data;
+
+auto operator[](const int index) const [[clang::lifetimebound]] ->
decltype(data[index]) {
+return data[index];
+}
+};
+
+int m
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From 55b433e5bad38b2ce359c480066b1b8c2917ebbf Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/include/clang
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From d040754092faa2106dc0b63af5e8bc7d7e1e47c2 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH 1/3] [Clang][Sema] fix crash of attribute transform
---
clang/include/c
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From d040754092faa2106dc0b63af5e8bc7d7e1e47c2 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH 1/2] [Clang][Sema] fix crash of attribute transform
---
clang/include/c
@@ -0,0 +1,17 @@
+// RUN: %clang_cc1 %s -verify -fsyntax-only
+
+// expected-no-diagnostics
+
+template
+struct Bar {
+int* data;
+
+auto operator[](const int index) const [[clang::lifetimebound]] ->
decltype(data[index]) {
+return data[index];
+}
+};
+
+int m
@@ -7083,8 +7087,9 @@ QualType TreeTransform::TransformAttributedType(
modifiedType != oldType->getModifiedType()) {
// TODO: this is really lame; we should really be rebuilding the
// equivalent type from first principles.
cor3ntin wrote:
This c
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/78088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/78088
>From d040754092faa2106dc0b63af5e8bc7d7e1e47c2 Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Sun, 14 Jan 2024 15:07:26 +0800
Subject: [PATCH] [Clang][Sema] fix crash of attribute transform
---
clang/include/clang
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qizhi Hu (jcsxky)
Changes
Try to fix [issue](https://github.com/llvm/llvm-project/issues/73619)
1. During transforming `FunctionProtoType`, if `ThisContext,` is `nullptr` and
`CurrentContext` is `ClassTemplateSpecializationDecl`, Construc
https://github.com/jcsxky created
https://github.com/llvm/llvm-project/pull/78088
Try to fix [issue](https://github.com/llvm/llvm-project/issues/73619)
1. During transforming `FunctionProtoType`, if `ThisContext,` is `nullptr` and
`CurrentContext` is `ClassTemplateSpecializationDecl`, Construc
40 matches
Mail list logo
