https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/78699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr approved this pull request.
https://github.com/llvm/llvm-project/pull/78699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
I tried a whole bunch of stuffs, this is the best we can do to improve
`LexIdentifierContinue`
https://github.com/llvm/llvm-project/pull/78699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/78699
>From 5b25a78e888086f5a9c25acab2dc446a85252ee4 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Fri, 19 Jan 2024 12:04:29 +0100
Subject: [PATCH 1/2] [Clang][NFC] Optimize isAsciiIdentifierContinue
Precompute
cor3ntin wrote:
I did try to apply the same treatment to the whitespace tables but it made
thing strictly worse
https://github.com/llvm/llvm-project/pull/78699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/78699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned
char c,
return AllowDollar && c == '$';
}
+
+LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) {
+ // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER
+ static constexp
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned
char c,
return AllowDollar && c == '$';
}
+
+LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) {
+ // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER
+ static constexp
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned
char c,
return AllowDollar && c == '$';
}
+
+LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) {
+ // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER
+ static constexp
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned
char c,
return AllowDollar && c == '$';
}
+
+LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) {
+ // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER
+ static constexp
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned
char c,
return AllowDollar && c == '$';
}
+
+LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) {
+ // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER
+ static constexp
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 30da0f5a359ab4a684c5fdf0f4dbed20bae10f99
5b25a78e888086f5a9c25acab2dc446a85252ee4 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
Precompute the isAsciiIdentifierContinue table which is on the hot path.
https://llvm-compile-time-tracker.com/compare.php?from=30da0f5a359ab4a684c5fdf0f4dbed20bae10f99&to=cb0e48db2b8193d2ee59c2a6e998317cb220d51
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/78699
Precompute the isAsciiIdentifierContinue table which is on the hot path.
https://llvm-compile-time-tracker.com/compare.php?from=30da0f5a359ab4a684c5fdf0f4dbed20bae10f99&to=cb0e48db2b8193d2ee59c2a6e998317cb220d51
14 matches
Mail list logo
