mstorsjo wrote:
I'd invoke @AaronBallman for feedback/guidance here, before deciding the
direction on this one.
https://github.com/llvm/llvm-project/pull/121442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
mati865 wrote:
I'd be fine with closing this PR and #10148 if that is the preferred solution.
https://github.com/llvm/llvm-project/pull/121442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/121442
From b4a5daabac693aa3021c81180a9d25ac34177f62 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Wed, 1 Jan 2025 21:38:49 +0100
Subject: [PATCH] [Clang][Driver] Declare win32 threads on Windo
https://github.com/mati865 converted_to_draft
https://github.com/llvm/llvm-project/pull/121442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -619,7 +619,13 @@ class ToolChain {
virtual bool SupportsEmbeddedBitcode() const { return false; }
/// getThreadModel() - Which thread model does this target use?
- virtual std::string getThreadModel() const { return "posix"; }
+ virtual std::string getThreadModel() c
mstorsjo wrote:
As background for other reviewers: GCC can be built with either the posix or
win32 thread model. This doesn't affect code generation much (at all?), but it
does affect libgcc and libstdc++ which are built in the same GCC build.
With the win32 thread model, libgcc/libstdc++ use
@@ -619,7 +619,13 @@ class ToolChain {
virtual bool SupportsEmbeddedBitcode() const { return false; }
/// getThreadModel() - Which thread model does this target use?
- virtual std::string getThreadModel() const { return "posix"; }
+ virtual std::string getThreadModel() c
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Mateusz Mikuła (mati865)
Changes
Fixes https://github.com/llvm/llvm-project/issues/10148
Recently I saw a user confused by it and thought Clang was using `winpthreads`.
Note: this does not change structures like
https://github.com
https://github.com/mati865 created
https://github.com/llvm/llvm-project/pull/121442
Fixes https://github.com/llvm/llvm-project/issues/10148
Recently I saw a user confused by it and thought Clang was using `winpthreads`.
Note: this does not change structures like
https://github.com/llvm/llvm-p
