[llvm] [clang-tools-extra] [clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

https://github.com/vfdff closed https://github.com/llvm/llvm-project/pull/78716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

itf wrote: @gribozavr, could we merge this fix? As a first-time contributor I think @chenshanzhi cannot merge it https://github.com/llvm/llvm-project/pull/78716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

https://github.com/chenshanzhi updated https://github.com/llvm/llvm-project/pull/78716 >From dcdf4a5825a402ab1392f61354c604a9cf965bdd Mon Sep 17 00:00:00 2001 From: Shanzhi Chen Date: Thu, 18 Jan 2024 11:40:09 + Subject: [PATCH] [Clang][AST] Fix a crash on attaching doc comments This crash

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

chenshanzhi wrote: @gribozavr Thanks for your reply! I'm really glad that I can get the explanation about the original aim of the relevant code from you! I do have considered merging the two loops as you recommended when I tried to solve the crash. But I got confused when I compared the impl

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

https://github.com/gribozavr approved this pull request. https://github.com/llvm/llvm-project/pull/78716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

gribozavr wrote: Thank you for the fix. Here's what happens here. This function receives the just-parsed decls, and its aim is to the comment in the same vicinity (I know this because I am the original author of the code). This first loop over `Decls` identifies the file in which we will be l

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

https://github.com/chenshanzhi edited https://github.com/llvm/llvm-project/pull/78716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Shanzhi (chenshanzhi) Changes This crash is basically caused by calling `ASTContext::getRawCommentForDeclNoCacheImp` with its input arguments `RepresentativeLocForDecl` and `CommentsInTheFile` refering to different files. A reduced reprod

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

https://github.com/chenshanzhi created https://github.com/llvm/llvm-project/pull/78716 This crash is basically caused by calling `ASTContext::getRawCommentForDeclNoCacheImp` with its input arguments `RepresentativeLocForDecl` and `CommentsInTheFile` refering to different files. A reduced repro