https://github.com/hnrklssn updated
https://github.com/llvm/llvm-project/pull/143739
>From d239fee7d5fd002edb08a24b4de1db84433413fe Mon Sep 17 00:00:00 2001
From: "Henrik G. Olsson"
Date: Wed, 11 Jun 2025 17:36:29 +0200
Subject: [PATCH] [Modules] Record whether VarDecl initializers contain side
ChuanqiXu9 wrote:
> > I think we shouldn't remove the assertion. Your test passes with the
> > removal of the assertion since the initializers are not complex. So it ends
> > quickly. But if it is a complex initialization which triggers more
> > deserialization, I feel it will be problematic.
hnrklssn wrote:
> I think we shouldn't remove the assertion. Your test passes with the removal
> of the assertion since the initializers are not complex. So it ends quickly.
> But if it is a complex initialization which triggers more deserialization, I
> feel it will be problematic.
>
> I thi
ChuanqiXu9 wrote:
I think we shouldn't remove the assertion. Your test passes with the removal of
the assertion since the initializers are not complex. So it ends quickly. But
if it is a complex initialization which triggers more deserialization, I feel
it will be problematic.
I think the poi
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Henrik G. Olsson (hnrklssn)
Changes
This assert was reportedly added to "Defensively ensure that
GetExternalDeclStmt protects itself from nested deserialization". In the tests
for https://github.com/swiftlang/swift/pull/81859 I wa
https://github.com/hnrklssn created
https://github.com/llvm/llvm-project/pull/143739
This assert was reportedly added to "Defensively ensure that
GetExternalDeclStmt protects itself from nested deserialization". In the tests
for https://github.com/swiftlang/swift/pull/81859 I was able to trigg
