https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/80322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/80322
>From c2b559f5853a50a54958f2d5f2410a94ca0f722e Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 1 Feb 2024 13:44:03 -0500
Subject: [PATCH] [AMDGPU] Diagnose unaligned atomic for amdgpu
AMDGPU does no
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/80322
>From 8cc0ecfe6723b7eb363a5eef2cd4b8630e6a2ac8 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 1 Feb 2024 13:44:03 -0500
Subject: [PATCH] [AMDGPU] Diagnose unaligned atomic for amdgpu
AMDGPU does no
yxsamliu wrote:
> You may want to check that we can still disable the error with
> `-Wno-error=atomic-alignment` passed via top-level options.
>
> Other than that LGTM.
Good point. Added a test
https://github.com/llvm/llvm-project/pull/80322
___
cfe
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/80322
>From 91c9113a986c90179d36ca33c6d4559cb946f746 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 1 Feb 2024 13:44:03 -0500
Subject: [PATCH] [AMDGPU] Diagnose unaligned atomic for amdgpu
AMDGPU does no
https://github.com/Artem-B approved this pull request.
You may want to check that we can still disable the error with
`-Wno-error=atomic-alignment` passed via top-level options.
Other than that LGTM.
https://github.com/llvm/llvm-project/pull/80322
__
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
AMDGPU does not support unaligned atomics, therefore make the warning an error.
This patch is transferred from
https://reviews.llvm.org/D99201
---
Full diff: https://github.com/llvm/llvm-project/
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/80322
AMDGPU does not support unaligned atomics, therefore make the warning an error.
This patch is transferred from
https://reviews.llvm.org/D99201
>From a5d78d7439d58eefc45a6ea694f1e4d941de9d10 Mon Sep 17 00:00:00
