https://github.com/ostannard closed
https://github.com/llvm/llvm-project/pull/124760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ostannard wrote:
I agree with @efriedma-quic that this is a very artificial test case, and I
wouldn't expect anyone to hit this in reality (I only noticed it while copying
the test for #124762), so it's not worth release-noting or adding a
compatibility option.
https://github.com/llvm/llvm-pr
efriedma-quic wrote:
The likelihood of anyone actually tripping over this outside a synthetic
testcase is very low; you need a combination of unusual constructs to hit this.
So I'm not really worried about documentation/ABI compat flags.
https://github.com/llvm/llvm-project/pull/124760
__
zygoloid wrote:
Also, is it worth adding `-fclang-abi-compat=` support to control this change?
https://github.com/llvm/llvm-project/pull/124760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
davemgreen wrote:
Is it worth adding a release note, if this is altering the ABI between versions?
https://github.com/llvm/llvm-project/pull/124760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/124760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oliver Stannard (ostannard)
Changes
We had a test claiming that this empty struct type consumes a register slot
when passing it to a function with GCC, but that does not appear to be the
case, at least with GCC versions going back to 4.8.
https://github.com/ostannard created
https://github.com/llvm/llvm-project/pull/124760
We had a test claiming that this empty struct type consumes a register slot
when passing it to a function with GCC, but that does not appear to be the
case, at least with GCC versions going back to 4.8.
This
