https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,59 @@
+// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
kovdan01 wrote:
Fixed, thanks, see 37a4d9d08fefd8c42c21b92ad2e3c1fa07fac126
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commit
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/85235
>From 919af72c09216838bfe586c3da503f5d74104a7d Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 19 Mar 2024 23:57:06 +0300
Subject: [PATCH 01/10] [PAC][clang] Define ptrauth driver flags and
preprocesso
@@ -1190,6 +1191,36 @@ void CodeGenModule::Release() {
if (!LangOpts.isSignReturnAddressWithAKey())
getModule().addModuleFlag(llvm::Module::Min,
"sign-return-address-with-bkey", 1);
+
+if (getTriple().isOSLinux() && getTriple().isOS
@@ -1190,6 +1191,36 @@ void CodeGenModule::Release() {
if (!LangOpts.isSignReturnAddressWithAKey())
getModule().addModuleFlag(llvm::Module::Min,
"sign-return-address-with-bkey", 1);
+
+if (getTriple().isOSLinux() && getTriple().isOS
@@ -0,0 +1,59 @@
+// RUN: %clang_cc1 -triple aarch64-linux -S -emit-llvm -o - \
MaskRay wrote:
`-S` should be removed. I've cleaned up the whole clang/test suite.
After https://github.com/llvm/llvm-project/pull/91140 this will lead to an
error.
https://github.
https://github.com/MaskRay approved this pull request.
This will need a rebase (or merge main) as `-S -emit-llvm` tests have errors.
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kovdan01 wrote:
@MaskRay Please let me know if you have some additional feedback after the
latest updates b0f9a1985846448d01af9bacdb6e3ddb23d4588f or if this can be
merged.
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
@@ -1796,6 +1796,26 @@ void Clang::AddAArch64TargetArgs(const ArgList &Args,
Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_intrinsics,
options::OPT_fno_ptrauth_intrinsics);
+
kovdan01 wrote:
Deleted, see b0f9a1985846448d01af9bacdb6e3d
@@ -1,5 +1,37 @@
+// RUN: %clang -### -c --target=aarch64 %s 2>&1 | FileCheck %s --check-prefix
NONE
+// NONE: "-cc1"
+// NONE-NOT: "-fptrauth-
+
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-intrinsics
-fptrauth-intrinsics %s 2>&1 | FileCheck %s --check-prefix=INTRIN
/
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/85235
>From 919af72c09216838bfe586c3da503f5d74104a7d Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 19 Mar 2024 23:57:06 +0300
Subject: [PATCH 1/9] [PAC][clang] Define ptrauth driver flags and preprocessor
@@ -1,5 +1,37 @@
+// RUN: %clang -### -c --target=aarch64 %s 2>&1 | FileCheck %s --check-prefix
NONE
+// NONE: "-cc1"
+// NONE-NOT: "-fptrauth-
+
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-intrinsics
-fptrauth-intrinsics %s 2>&1 | FileCheck %s --check-prefix=INTRIN
/
@@ -1796,6 +1796,26 @@ void Clang::AddAArch64TargetArgs(const ArgList &Args,
Args.addOptInFlag(CmdArgs, options::OPT_fptrauth_intrinsics,
options::OPT_fno_ptrauth_intrinsics);
+
MaskRay wrote:
I'd delete blank lines for these similar `OP
@@ -1,5 +1,37 @@
+// RUN: %clang -### -c --target=aarch64 %s 2>&1 | FileCheck %s --check-prefix
NONE
+// NONE: "-cc1"
+// NONE-NOT: "-fptrauth-
+
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-intrinsics
-fptrauth-intrinsics %s 2>&1 | FileCheck %s --check-prefix=INTRIN
/
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,5 +1,37 @@
+// RUN: %clang -### -c --target=aarch64 %s 2>&1 | FileCheck %s --check-prefix
NONE
+// NONE: "-cc1"
+// NONE-NOT: "-fptrauth-
+
// RUN: %clang -### -c --target=aarch64 -fno-ptrauth-intrinsics
-fptrauth-intrinsics %s 2>&1 | FileCheck %s --check-prefix=INTRIN
/
kovdan01 wrote:
@MaskRay I've addressed your latest comments in
fdb26a14024f5f8297480a74982a37ee988cd30f - would be glad to see your feedback
on the changes
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
cfe-commits@list
@@ -0,0 +1,59 @@
+// RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \
kovdan01 wrote:
Fixed, thanks, see fdb26a14024f5f8297480a74982a37ee988cd30f
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits m
https://github.com/kovdan01 updated
https://github.com/llvm/llvm-project/pull/85235
>From 919af72c09216838bfe586c3da503f5d74104a7d Mon Sep 17 00:00:00 2001
From: Daniil Kovalev
Date: Tue, 19 Mar 2024 23:57:06 +0300
Subject: [PATCH 1/8] [PAC][clang] Define ptrauth driver flags and preprocessor
@@ -0,0 +1,59 @@
+// RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \
MaskRay wrote:
We prefer `%clang_cc1` for codegen tests. `%clang` is not used in
clang/test/Driver
https://github.com/llvm/llvm-project/pull/85235
_
kovdan01 wrote:
@MaskRay Please see fixes for your previous comments in several latest commits.
Would be glad to see new feedback on the PR. Note: the buildkite failure on
Windows is flang-related and not related to these changes.
https://github.com/llvm/llvm-project/pull/85235
___
kovdan01 wrote:
@MaskRay A kind reminder regarding the PR - please let me know if latest
updates address your previous comments and if there are other issues still
present.
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
https://github.com/kovdan01 edited
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
26 matches
Mail list logo
