Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

2016-05-24 Thread Bob Wilson via cfe-commits
> On May 24, 2016, at 11:46 AM, Manman Ren wrote: > >> >> On May 24, 2016, at 11:42 AM, Bob Wilson > > wrote: >> >>> >>> On May 24, 2016, at 11:21 AM, Manman >> > wrote: >>> >>> On May 23, 2016, at 8:15 PM, Bob Wilson >>>

Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

2016-05-24 Thread Manman Ren via cfe-commits
> On May 24, 2016, at 11:42 AM, Bob Wilson wrote: > >> >> On May 24, 2016, at 11:21 AM, Manman wrote: >> >> >>> On May 23, 2016, at 8:15 PM, Bob Wilson wrote: >>> >>> Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for >>> Objective-C properties marked with the IBOutle

Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

2016-05-24 Thread Bob Wilson via cfe-commits
> On May 24, 2016, at 11:21 AM, Manman wrote: > > >> On May 23, 2016, at 8:15 PM, Bob Wilson wrote: >> >> Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for >> Objective-C properties marked with the IBOutlet attribute. Those properties >> are supposed to be weak but the

Re: [PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

2016-05-24 Thread Manman via cfe-commits
> On May 23, 2016, at 8:15 PM, Bob Wilson wrote: > > Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for > Objective-C properties marked with the IBOutlet attribute. Those properties > are supposed to be weak but they are only accessed from the main thread so > there is no

[PATCH] arc-repeated-use-of-weak should not warn about IBOutlet properties

2016-05-23 Thread Bob Wilson via cfe-commits
Revision r211132 was supposed to disable -Warc-repeated-use-of-weak for Objective-C properties marked with the IBOutlet attribute. Those properties are supposed to be weak but they are only accessed from the main thread so there is no risk of asynchronous updates setting them to nil. That combin