Re: [PATCH] Have clang list the imported modules in the debug info

On Mon, Aug 24, 2015 at 5:33 PM, Adrian Prantl wrote: > > On Aug 24, 2015, at 4:17 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl wrote: > >> >> On Aug 24, 2015, at 2:01 PM, David Blaikie wrote: >> >> >> >> On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote:

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 24, 2015, at 4:17 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl > wrote: > >> On Aug 24, 2015, at 2:01 PM, David Blaikie > > wrote: >> >> >> >> On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl >

Re: [PATCH] Have clang list the imported modules in the debug info

On Mon, Aug 24, 2015 at 3:34 PM, Adrian Prantl wrote: > > On Aug 24, 2015, at 2:01 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote: > >> >> On Aug 19, 2015, at 1:20 PM, David Blaikie wrote: >> >> >> >> On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl wrote:

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 24, 2015, at 2:01 PM, David Blaikie wrote: > > > > On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl > wrote: > >> On Aug 19, 2015, at 1:20 PM, David Blaikie > > wrote: >> >> >> >> On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl >

Re: [PATCH] Have clang list the imported modules in the debug info

+static void escape(llvm::raw_ostream &OS, StringRef String) { + for (auto C: String) { +if (strchr("\\\"", C)) + OS << '\\'; +OS << C; + } +} Do we not have an existing function somewhere to do that? Also, that strchr call is a very complex way of writing (C == '\\' || C == '"') O

Re: [PATCH] Have clang list the imported modules in the debug info

On Mon, Aug 24, 2015 at 1:23 PM, Adrian Prantl wrote: > > On Aug 19, 2015, at 1:20 PM, David Blaikie wrote: > > > > On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl wrote: > >> >> On Jul 24, 2015, at 12:33 PM, David Blaikie wrote: >> >> *reads back through the thread* >> >> >> appreciated, it’s

Re: [PATCH] Have clang list the imported modules in the debug info

> On Aug 19, 2015, at 1:20 PM, David Blaikie wrote: > > > > On Mon, Aug 10, 2015 at 5:00 PM, Adrian Prantl > wrote: > >> On Jul 24, 2015, at 12:33 PM, David Blaikie > > wrote: >> >> *reads back through the thread* > > appreciated, it’s l

Fwd: [PATCH] Have clang list the imported modules in the debug info

(add the right list) -- Forwarded message -- From: David Blaikie Date: Wed, Aug 19, 2015 at 1:20 PM Subject: Re: [PATCH] Have clang list the imported modules in the debug info To: Adrian Prantl Cc: Eric Christopher , Zachary Turner < ztur...@google.com>, "Rob

Re: [PATCH] Have clang list the imported modules in the debug info

(ping.) > On Aug 10, 2015, at 5:03 PM, Adrian Prantl wrote: > > [resending because I accidentally sent this to the old mailing list]. > >> On Jul 24, 2015, at 12:33 PM, David Blaikie > > wrote: >> >> *reads back through the thread* > > appreciated, it’s long :-) >

Re: [PATCH] Have clang list the imported modules in the debug info

[resending because I accidentally sent this to the old mailing list]. > On Jul 24, 2015, at 12:33 PM, David Blaikie > wrote: > > *reads back through the thread* appreciated, it’s long :-) > So what I originally had in mind about a year ago when we discussed this, was