Re: [PATCH] Fix crash in CheckObjCCircularContainer

2015-08-05 Thread Argyrios Kyrtzidis
> +IdentifierInfo *II = &S.Context.Idents.get(InterfaceDecl->getName()); You can just do “InterfaceDecl->getIdentifier()”, no need to lookup by string. Also this will eliminate the need to pass Sema as parameter. And ‘isSubclassOfNSClass()’ seems generally useful, how about you make it a fu

Re: [PATCH] Fix crash in CheckObjCCircularContainer

2015-08-05 Thread AlexDenisov
> Why not get the IdentifierInfo pointer for the class name from the NSAPI > object and compare that ? There are more than one way to do things, it’s just lack of knowledge about the code base. > Also there is code duplication, since the same code pattern is used in 3 > places, could you refact

Re: [PATCH] Fix crash in CheckObjCCircularContainer

2015-08-05 Thread AlexDenisov
Hi guys, any updates? -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 31 Jul 2015, at 22:55, AlexDenisov <1101.deb...@gmail.com> wrote: > >> To clarify, are you saying that the warning may lead to false positives when >> used in subclasses ? > > Seems I was wrong. > Just checked