Re: [PATCH] Don't crash when dumping objc_bridge_related attributes

2015-11-30 Thread Aaron Ballman via cfe-commits
On Thu, Nov 26, 2015 at 12:00 PM, Joe Ranieri wrote: > On Thu, Nov 26, 2015 at 11:29 AM, Aaron Ballman > wrote: >> On Wed, Nov 25, 2015 at 6:13 PM, Joe Ranieri wrote: >>> Clang's AST dumping currently crashes when dumping objc_bridge_related >>> attributes where the class method and instance me

Re: [PATCH] Don't crash when dumping objc_bridge_related attributes

2015-11-26 Thread Joe Ranieri via cfe-commits
On Thu, Nov 26, 2015 at 11:29 AM, Aaron Ballman wrote: > On Wed, Nov 25, 2015 at 6:13 PM, Joe Ranieri wrote: >> Clang's AST dumping currently crashes when dumping objc_bridge_related >> attributes where the class method and instance method fields are left >> empty. The attached patch marks the tw

Re: [PATCH] Don't crash when dumping objc_bridge_related attributes

2015-11-26 Thread Aaron Ballman via cfe-commits
On Wed, Nov 25, 2015 at 6:13 PM, Joe Ranieri wrote: > Clang's AST dumping currently crashes when dumping objc_bridge_related > attributes where the class method and instance method fields are left > empty. The attached patch marks the two arguments as optional and > updates TableGen to understand

[PATCH] Don't crash when dumping objc_bridge_related attributes

2015-11-25 Thread Joe Ranieri via cfe-commits
Clang's AST dumping currently crashes when dumping objc_bridge_related attributes where the class method and instance method fields are left empty. The attached patch marks the two arguments as optional and updates TableGen to understand the optional flag for identifier attribute arguments when gen