This revision was automatically updated to reflect the committed changes.
dgoldman marked an inline comment as done.
Closed by commit rG39866d249a21: [clangd][ObjC] Improve support for class
properties (authored by dgoldman).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
dgoldman marked 2 inline comments as done.
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313
+// FIXME: visiting this here allows us to hover on UIColor in
+// `UIColor.blackColor` but then `blackColor` no longer refers to
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313
+// FIXME: visiting this here allows us to hover on UIColor in
+// `UIColor.blackColor`
dgoldman updated this revision to Diff 340885.
dgoldman marked 2 inline comments as done.
dgoldman added a comment.
Fixes for review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99975/new/
https://reviews.llvm.org/D99975
Files:
clang-tools-extr
dgoldman updated this revision to Diff 340840.
dgoldman added a comment.
Rebase on top of main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99975/new/
https://reviews.llvm.org/D99975
Files:
clang-tools-extra/clangd/FindTarget.cpp
clang-tools-
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313
+// FIXME: visiting this here allows us to hover on UIColor in
+// `UIColor.blackColor` but then `blackColor` no longer refers to the
+// method.
+// if (OP
sammccall added inline comments.
Herald added a subscriber: cfe-commits.
Comment at: clang-tools-extra/clangd/FindTarget.cpp:309-313
+// FIXME: visiting this here allows us to hover on UIColor in
+// `UIColor.blackColor` but then `blackColor` no longer refers to t
