[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1316 Stmt *SubStmt) { -return SemaRef.ActOnAttributedStmt(AttrLoc, Attrs, SubStmt); +return SemaRef.BuildAttributedStmt(AttrLoc, Attrs, SubStmt); } -

[PATCH] D99896: Rework the way statement attributes are processed; NFC

haberman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1316 Stmt *SubStmt) { -return SemaRef.ActOnAttributedStmt(AttrLoc, Attrs, SubStmt); +return SemaRef.BuildAttributedStmt(AttrLoc, Attrs, SubStmt); } --

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in 978d2edf7aed133616de1eb7f633c263c4b5 , thanks for the really quick reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1316 Stmt *SubStmt) { -return SemaRef.ActOnAttributedStmt(AttrLoc, Attrs, SubStmt); +return SemaRef.BuildAttributedStmt(AttrLoc, Attrs, SubStmt); } -

[PATCH] D99896: Rework the way statement attributes are processed; NFC

haberman added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1316 Stmt *SubStmt) { -return SemaRef.ActOnAttributedStmt(AttrLoc, Attrs, SubStmt); +return SemaRef.BuildAttributedStmt(AttrLoc, Attrs, SubStmt); } --

[PATCH] D99896: Rework the way statement attributes are processed; NFC

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. SGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99896/new/ https://reviews.llvm.org/D99896

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman added a comment. In D99896#2669471 , @erichkeane wrote: > It is really sad that the attributes can't 'auto transform' themselves. > ParsedAttr could (since it has a union of expressions/identifiers), but we > don't really seem to have a go

[PATCH] D99896: Rework the way statement attributes are processed; NFC

erichkeane added a comment. It is really sad that the attributes can't 'auto transform' themselves. ParsedAttr could (since it has a union of expressions/identifiers), but we don't really seem to have a good way to do it for Attr. Could we possibly do some table-gen to auto create the 'simple'

[PATCH] D99896: Rework the way statement attributes are processed; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, haberman, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. This changes our approach to processing statement attributes to be more similar to how we process declaration attribute