[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

2021-04-02 Thread ChenZheng via Phabricator via cfe-commits
shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3974 + // Microsoft debuggers don't handle missing end columns well, and the AIX + // debugger DBX also doesn't handle the columns well, so it's bettre not to + // include any column info. ---

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

2021-04-02 Thread ChenZheng via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf026e1f52055: [debug-info][XCOFF] set `-gno-column-info` by default for DBX (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D99703?vs=334589&id=334879#toc Repository: rG LLVM

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

2021-04-01 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3974 + // Microsoft debuggers don't handle missing end columns well, and the AIX + // debugger DBX a

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

2021-04-01 Thread ChenZheng via Phabricator via cfe-commits
shchenz created this revision. shchenz added reviewers: dblaikie, aprantl, jsji, probinson, echristo, PowerPC. shchenz added a project: debug-info. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For DBX, it does not handle column i