[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-04-02 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 closed this revision. jyu2 added a comment. cb424fee3d6b27dbd38de666382b702100935286 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D9967

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-04-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 ___ c

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-04-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: jyu2 wrote: > ABataev wrote: > > What about other directives? > Hi Alexey, > > As of now "

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-04-02 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: ABataev wrote: > What about other directives? Hi Alexey, As of now "novariants" clause only a

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-04-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:13567-13568 +case OMPD_dispatch: + CaptureRegion = OMPD_task; + break; +default: What about other directives? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-04-02 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 334969. jyu2 added a comment. Thank you, Alexey for the review!!! This changes have been addressed as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 Files:

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-04-02 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7659 +/// clause with condition 'a > 5'. +class OMPNovariantsClause : public OMPClause, public OMPClauseWithPreInit { + friend class OMPClauseReader; `final` Com

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-04-02 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 updated this revision to Diff 334956. jyu2 added a comment. Fix format problem as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99679/new/ https://reviews.llvm.org/D99679 Files: clang/include/clang/AST/OpenMPClause.h clang/incl

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

2021-03-31 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 created this revision. jyu2 added reviewers: mikerice, ABataev, jdoerfert. jyu2 added projects: LLVM, clang. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: sscalpone. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Added basic parsi