This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG98a3ff9d0525: [RISCV][Clang] Add more RVV Floating-Point
intrinsic functions. (authored by khchen).
Repository:
rG LLVM Github Monorepo
CHANGES S
khchen updated this revision to Diff 336117.
khchen added a comment.
rebase.
I don't know why `let` cannot overide field when we change instantiate single
multiclasses to inheritance.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99669/new/
https
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99669/new/
https://reviews.llvm.org/D99669
_
khchen updated this revision to Diff 335846.
khchen marked 4 inline comments as done.
khchen added a comment.
address Craig's comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99669/new/
https://reviews.llvm.org/D99669
Files:
clang/include
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:315
+multiclass RVVFloatingWidenTerBuiltinSet {
+ let HasMaskedOffOperand = false, Log2LMUL = [-2, -1, 0, 1, 2] in {
+defm "" : RVVOutOp1Op2BuiltinSet HsiangKai wrote:
> > why is there
khchen marked 2 inline comments as done.
khchen added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:315
+multiclass RVVFloatingWidenTerBuiltinSet {
+ let HasMaskedOffOperand = false, Log2LMUL = [-2, -1, 0, 1, 2] in {
+defm "" : RVVOutOp1Op2BuiltinSet
HsiangKai added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:315
+multiclass RVVFloatingWidenTerBuiltinSet {
+ let HasMaskedOffOperand = false, Log2LMUL = [-2, -1, 0, 1, 2] in {
+defm "" : RVVOutOp1Op2BuiltinSethttps://reviews.llvm.org/D99669/new/
khchen updated this revision to Diff 334659.
khchen added a comment.
rebase and refine multiclass.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99669/new/
https://reviews.llvm.org/D99669
Files:
clang/include/clang/Basic/riscv_vector.td
clang/
khchen created this revision.
khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy,
jrtc27.
Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos,
sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,
brucehoult, MartinMosbeck, edward
