[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

amccarth added a comment. Sorry, I think I've lost track of some context while I was on vacation. I don't understand why several of the tests are now unsupported on Windows. Some of those seem like important tests. If canonicalizing the file names to the platform's native style creates new t

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 336057. kamleshbhalui added a comment. Making changes effective only for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebu

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a reviewer: rnk. kamleshbhalui added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 ___ cfe-commits mailing list cfe-commits

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334952. kamleshbhalui added a comment. Making changes effective only for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebu

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

amccarth added a comment. In D99580#2660040 , @kamleshbhalui wrote: > In D99580#2659858 , @amccarth wrote: > >> It looks like the code change is for everyone, but the new test is specific >> to mingw. > > For Linu

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334359. kamleshbhalui added a comment. updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeG

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334356. kamleshbhalui added a comment. clang formatting the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 Files: clang/lib/CodeGen/CGDebugInfo.cpp cl

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui updated this revision to Diff 334338. kamleshbhalui added a comment. Marked failed tests as unsupported on windows system Because now clang emits native path for DIFile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https:/

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a comment. In D99580#2659352 , @dblaikie wrote: > @rnk @akhuang - I think we touched on this before maybe in some other > thread/patch/discussion? > > Ah, @probinson mentioned in the linked thread: > >> Is this https://bugs.llvm.org/sh

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a comment. In D99580#2659858 , @amccarth wrote: > Another possible issue is that llvm::sys::path and other functions try to map > Windows filesystem concepts to Posix ones. There are many cases where there > isn't a perfect mapping. F

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

amccarth added a comment. The previous discussions (that I participated in) were centered around the redirecting virtual filesystem, which creates paths in hybrid style and there is no "correct" way to make those native without taking breaking changes and making it less useful for writing platf

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

dblaikie added subscribers: akhuang, probinson, rnk. dblaikie added a comment. @rnk @akhuang - I think we touched on this before maybe in some other thread/patch/discussion? Ah, @probinson mentioned in the linked thread: > Is this https://bugs.llvm.org/show_bug.cgi?id=44170 which had a tentativ

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui created this revision. kamleshbhalui added reviewers: dblaikie, aprantl. kamleshbhalui added a project: LLVM. Herald added a subscriber: mstorsjo. kamleshbhalui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang emits dupli