[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

JonChesterfield added a comment. It's a hack, but D108303 will unblock nvptx offloading. Alternative to reverting. Suggest we go with that then revisit in a couple of weeks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2952336 , @JonChesterfield wrote: > Nvptx broken here too, amdgpu is fine. I'm guessing one of the cuda tools > does some overly aggressive input validation that we're running afoul of. > > There was a discussion about

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

JonChesterfield added a comment. Nvptx broken here too, amdgpu is fine. I'm guessing one of the cuda tools does some overly aggressive input validation that we're running afoul of. There was a discussion about this on the call today - plan was to put it behind a disabled boolean argument while

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2950522 , @jhuber6 wrote: > In D99551#2950515 , @vzakhari wrote: > >> In D99551#2950464 , @jhuber6 wrote: >> >>> In D99551#2950281

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. In D99551#2950515 , @vzakhari wrote: > In D99551#2950464 , @jhuber6 wrote: > >> In D99551#2950281 , @vzakhari wrote: >> >>> @jhuber6, thank you for r

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. In D99551#2950464 , @jhuber6 wrote: > In D99551#2950281 , @vzakhari wrote: > >> @jhuber6, thank you for reporting this. I do not have a properly setup CUDA >> system currently. Can you p

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. In D99551#2950281 , @vzakhari wrote: > @jhuber6, thank you for reporting this. I do not have a properly setup CUDA > system currently. Can you please invoke `clang-offload-wrapper` with > `-save-temps` and send the temporary fi

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari added a comment. @jhuber6, thank you for reporting this. I do not have a properly setup CUDA system currently. Can you please invoke `clang-offload-wrapper` with `-save-temps` and send the temporary files to me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

jhuber6 added a comment. This patch broke offloading on my machine. If I compile a basic offloading application I get an invalid device image. #include int main() { int isHost; #pragma omp target map(from:isHost) { isHost = omp_is_initial_device(); } return isHost; } Com

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93d08acaacec: [clang-offload-wrapper] Add standard notes for ELF offload images (authored by vzakhari). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 364193. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D99551 Files: clang/test/Driver/Inputs/empty-elf-template.yaml clang/test/Driver/clang-offload-wrapper.c clang/tools/clang-offload-wrapper/CMakeLists.txt

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

grokos accepted this revision. grokos added a comment. This revision is now accepted and ready to land. Change looks good, so it's accepted on my end. I'll let the other reviewers have a look and post their comments. Please do not commit until we have reached an agreement for all 4 patches toget

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334292. vzakhari added a comment. Herald added a subscriber: mgorny. Updated revision fixes //BUILD_SHARED_LIBS// build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D99551 Files: clang/test/Driver/Inputs/emp

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334282. vzakhari added a comment. I am not sure what is wrong with the uploaded ELF files. The test works locally. Let's try it with a thinner YAML template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D9955

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari updated this revision to Diff 334233. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99551/new/ https://reviews.llvm.org/D99551 Files: clang/test/Driver/Inputs/clang-offload-wrapper/elf32be clang/test/Driver/Inputs/clang-offload-wrapper/elf32le clang/test/Driver/Inputs/clan

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari created this revision. vzakhari added reviewers: ABataev, sdmitriev, grokos. vzakhari added a project: OpenMP. Herald added a reviewer: alexshap. vzakhari requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. H