This revision was automatically updated to reflect the committed changes.
Closed by commit rGb662651586be: [clangd] Use command line adjusters for
inserting compile flags (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99523/new
kadircet updated this revision to Diff 348972.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99523/new/
https://reviews.llvm.org/D99523
Files:
clang-tools-extra/clangd/CompileCommands.cpp
clang-tool
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:271
Out.Apply.push_back([Add(std::move(Add))](const Params &, Config &C) {
C.CompileFlags.Edits.push_back([Add](std::vector &Args) {
+
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: cfe-commits.
Thanks for fixing!
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:225
+ Cmd = tooling::getInsertArgumentAdjuster(
+
