[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. Thanks MaskRay for your review comments! Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1752 + else { +UniqueID = NextUniqueID++; +COMDATSymName = MBB.getParent()->getName(); MaskRay wrote: > I think `UniqueID = N

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 367407. TaoPan added a comment. Fix Windows gnu section name and test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: clang/include/clang/Driver/Options.td

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

MaskRay added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1752 + else { +UniqueID = NextUniqueID++; +COMDATSymName = MBB.getParent()->getName(); I think `UniqueID = NextUniqueID++;` is not needed. Com

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. @rnk Thanks for your review comments! Could you please help to review my reply and new modification? @MaskRay Could you please also help to review? Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1712 + COFF::IMAGE_SCN_MEM_READ |

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 364013. TaoPan added a comment. Change selection of entry block text section from IMAGE_COMDAT_SELECT_ANY to return value of getSelectionForCOFF() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https:

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

rnk added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1712 + COFF::IMAGE_SCN_MEM_READ | COFF::IMAGE_SCN_LNK_COMDAT, + SectionKind::getText(), COMDATSymName, + COFF::IMAGE_COMDAT_SELECT_NODUPLICATES, UniqueID);

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. @rnk could you please have a review of IMAGE_COMDAT_SELECT_XXX modification? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 ___ cfe-commi

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1712 + COFF::IMAGE_SCN_MEM_READ | COFF::IMAGE_SCN_LNK_COMDAT, + SectionKind::getText(), COMDATSymName, + COFF::IMAGE_COMDAT_SELECT_NODUPLICATES, UniqueID); -

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 358481. TaoPan added a comment. Change select of BB sections to IMAGE_COMDAT_SELECT_NODUPLICATES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: clang/include/c

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 356874. TaoPan added a comment. git rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/C

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 356864. TaoPan added a comment. Update dependent D99487 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 Files: llvm/lib/CodeGen/AsmPr

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. I reported bugs of using clang-cl and lld to test https://github.com/microsoft/compiler-tests/tree/master/seh 2. clang-cl.exe + lld linker a. x4ptcu.c: build error https://bugs.llvm.org/show_bug.cgi?id=50859 b. seh0015.c, seh0017.c: build crash https://bugs.llvm.

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan added a comment. In D99487#2832079 , @modimo wrote: > In D99487#2821343 , @TaoPan wrote: > >> I checked the microsoft SEH tests with >> >> 1. cl.exe >> >> a. x4ptcu.c: build error >> 2. clang-cl.exe + lld l

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

TaoPan updated this revision to Diff 353844. TaoPan added a comment. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. Make clang option -fbasic-block-sections and -funique-basic-block-section-names available on Windows COFF. Repository: rG LLVM Github Monorepo CHAN