[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99459/new/ https://reviews.llvm.org/D99459 ___ c

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600-2604 + RValue FactorRVal = EmitAnyExpr(FactorExpr, AggValueSlot::ignored(), + /*ignoreResult=*/true); +

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600-2604 + RValue FactorRVal = EmitAnyExpr(FactorExpr, AggValueSlot::ignored(), + /*ignoreResult=*/true); + Factor = + cast(FactorRVal.getScalarV

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12821 +/// Determine whether an expression is constant without emitting diagnostic. +static bool isConstantExpression(Sema &SemaRef, Expr *E) { + struct ConstTripcountDiagnoser : public Sema::VerifyICEDiagn

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur marked 8 inline comments as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:463-478 + static const SpecificClause *getSingleClause(ArrayRef Clauses) { +auto ClausesOfKind = getClausesOfKind(Clauses); -if (Clauses.begi

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:907 + /// \param C Context of the AST. + /// \param Loc Location of the 'full' identifier. + static OMPFullClause *Create(const ASTContext &C, SourceLocation StartLoc, Fix para

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

ABataev added a comment. Some previous comments were not addressed yet Comment at: clang/include/clang/AST/OpenMPClause.h:972-974 + /// Sets the location of '('. + void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; } + Make it private

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur added a comment. Removed [WIP] flag; ready to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99459/new/ https://reviews.llvm.org/D99459 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'. WIP.

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:899 +public: + /// Build a 'sizes' AST node. + /// `sizes`->`full` Comment at: clang/include/clang/AST/OpenMPClause.h:902 + /// \param C Context of the

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'. WIP.

Meinersbur created this revision. Meinersbur added projects: OpenMP, clang. Herald added subscribers: dexonsmith, martong, arphaman, zzheng, guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sste