[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok marked an inline comment as done. alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs,

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

dblaikie added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) alok

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok marked 2 inline comments as done. alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs,

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

dblaikie added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) prob

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

probinson added a reviewer: dblaikie. probinson added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArc

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok updated this revision to Diff 334642. alok added a comment. Updated to address comments from @djtodoro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99238/new/ https://reviews.llvm.org/D99238 Files: clang/include/clang/Basic/CodeGenOptions.def clang/lib/Frontend/CompilerInvoca

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) djtodoro

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

djtodoro added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) I am

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok updated this revision to Diff 332870. alok added a comment. Re-based after setting the parent patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99238/new/ https://reviews.llvm.org/D99238 Files: clang/include/clang/Basic/CodeGenOptions.def clang/lib/Frontend/CompilerInvocati

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

alok created this revision. alok added reviewers: djtodoro, aprantl, jmorse, SouraVX, jini.susan.george, bhuvanendrakumarn. alok added a project: debug-info. Herald added subscribers: jansvoboda11, dexonsmith. alok requested review of this revision. Herald added projects: clang, LLVM. Herald added