This revision was automatically updated to reflect the committed changes.
Closed by commit rG4821c15691ba: [analyzer] Fix body farm for Obj-C++
properties (authored by vsavchenko).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99194/new/
https://rev
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Great, thanks!~
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99194/new/
https://reviews.llvm.org/D99194
vsavchenko updated this revision to Diff 335615.
vsavchenko added a comment.
Set Prop and IVar at the same time
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99194/new/
https://reviews.llvm.org/D99194
Files:
clang/lib/Analysis/BodyFarm.cpp
cla
vsavchenko added inline comments.
Comment at: clang/lib/Analysis/BodyFarm.cpp:757
+ if (PI->getPropertyDecl()) {
+Prop = PI->getPropertyDecl();
+if (Prop->getGetterName() == MD->getSelector())
NoQ wrote:
> At this point `Prop` may contain a c
NoQ added inline comments.
Comment at: clang/lib/Analysis/BodyFarm.cpp:757
+ if (PI->getPropertyDecl()) {
+Prop = PI->getPropertyDecl();
+if (Prop->getGetterName() == MD->getSelector())
At this point `Prop` may contain a completely unrelated
steakhal resigned from this revision.
steakhal added a comment.
Herald added a subscriber: steakhal.
I'm not familiar with Objective-C.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99194/new/
https://reviews.llvm.org/D99194
__
vsavchenko created this revision.
vsavchenko added reviewers: NoQ, xazax.hun, steakhal, ASDenysPetrov.
Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, kristof.beyls.
vsavchenko requested review of this revision.
H
