This revision was automatically updated to reflect the committed changes.
Closed by commit rG88c2d4c8eb0e: [RISCV][Clang] Add RVV Vector Indexed Load
intrinsic functions. (authored by khchen).
Changed prior to commit:
https://reviews.llvm.org/D98848?vs=332660&id=332850#toc
Repository:
rG LLV
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:23
#include "llvm/ADT/Twine.h"
+#include "llvm/Support/Regex.h"
#include "llvm/TableGen/Error.h"
---
liaolucy added a comment.
LGTM, thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98848/new/
https://reviews.llvm.org/D98848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
khchen updated this revision to Diff 332660.
khchen marked 8 inline comments as done.
khchen added a comment.
1. address Craig's comments.
2. add 'REQUIRES: riscv-registered-target' for tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98848/new/
craig.topper added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:90
+// equivalent integer vector type with EEW and corresponding ELMUL (elmul
=
+// (eew/sew) * lmul). Fore example, vector type is __rvv_float16m4
+// (SEW=16, LMUL=4) and L
khchen updated this revision to Diff 332341.
khchen added a comment.
update tests, remove target-feature zfh.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98848/new/
https://reviews.llvm.org/D98848
Files:
clang/include/clang/Basic/riscv_vector.
khchen updated this revision to Diff 332307.
khchen added a comment.
Remove half type in TypeList.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98848/new/
https://reviews.llvm.org/D98848
Files:
clang/include/clang/Basic/riscv_vector.td
clang/
khchen created this revision.
khchen added reviewers: craig.topper, jrtc27, rogfer01, frasercrmck, HsiangKai,
evandro.
Herald added subscribers: vkmr, dexonsmith, luismarques, apazos,
sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o,
brucehoult, MartinMosbeck, edward