This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG128ce70eef99: [CodeCompletion] Avoid spurious signature help
for init-list args (authored by sammccall).
Herald added a project: clang-tools-extra.
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang/lib/Parse/Parser.cpp:2117
if (S->getFlags() & Scope::FnScope) {
+ cutOffParsing();
Actions.CodeCompleteOrdinaryName(getCu
sammccall updated this revision to Diff 330218.
sammccall added a comment.
oops, enable clangd test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98488/new/
https://reviews.llvm.org/D98488
Files:
clang-tools-extra/clangd/unittests/CodeCompleteTe
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Somewhat surprisingly, signature help is emitted as a side-effec
