This revision was automatically updated to reflect the committed changes.
Closed by commit rGb447445eaa6f: [clangd] Show padding following a field on
field hover. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D98377?vs=329805&id=355571#toc
Repository:
rG LLVM Git
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
Herald added a project: clang-tools-extra.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98377/new/
https://reviews.llvm.org/D
sammccall updated this revision to Diff 329805.
sammccall added a comment.
Stop reporting offset for fields in a union, too
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98377/new/
https://reviews.llvm.org/D98377
Files:
clang-tools-extra/clangd/
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:105
+ HI.Size = 1;
+ HI.Padding = 15;
+ HI.AccessSpecifier = "public";
njames93 wrote:
> Does it make any sense to include the padding for union
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:105
+ HI.Size = 1;
+ HI.Padding = 15;
+ HI.AccessSpecifier = "public";
Does it make any sense to include the padding for union fields?
Reposito
sammccall created this revision.
sammccall added a reviewer: kbobyrev.
Herald added subscribers: usaxena95, kadircet, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
This displays as: `Size: 4 byte
