sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Herald added a project: clang-tools-extra.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:678
}
- Server->addDocument(File, NewCode,
encodeVersion(Pa
njames93 added a comment.
I've cleaned some changes up a bit. I do agree its not as important as the
dirty buffer case, but this is about uniformity as much as anything.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98364/new/
https://reviews.llvm
njames93 updated this revision to Diff 329939.
njames93 added a comment.
Remove other unnecessary ownership.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98364/new/
https://reviews.llvm.org/D98364
Files:
clang-tools-extra/clangd/ClangdLSPServer
njames93 updated this revision to Diff 329933.
njames93 marked 4 inline comments as done.
njames93 added a comment.
Remove some unneeded changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98364/new/
https://reviews.llvm.org/D98364
Files:
cla
sammccall added a comment.
Avoiding copies seems nice, but this makes some interfaces more awkward. Do you
have any measurements that some of these copies matter?
(The dirty FS changes avoided coping all the dirty buffers at once, but it
seems like these changes will mostly save ~1 file copy pe
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.h:195-198
void addDocument(PathRef File, StringRef Contents,
llvm::StringRef Version = "null",
WantDiagnostics WD = WantDiagnostics::Auto,
njames93 created this revision.
njames93 added reviewers: sammccall, kadircet.
Herald added subscribers: usaxena95, arphaman, javed.absar.
njames93 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM
