[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-04 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. thanks, this is much needed documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 328227. MaskRay added a comment. Add more information to --gcc-toolchain. Reference --gcc-toolchain in --prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 Files:

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-04 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the comp

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 328220. MaskRay marked 2 inline comments as done. MaskRay added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 Files: clang/docs/ClangCommandLine

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the compiler. If

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-04 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Thanks for the patch! It is a much needed clarification! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 ___ cfe-commits mailing

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-04 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the comp

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a subscriber: aaron.ballman. MaskRay added a comment. This is motivated by Linux kernel folks' confusion on `--gcc-toolchain` https://lore.kernel.org/linux-kbuild/20210303230708.l6pbk5o5nc2qa...@google.com/ (it confused me, even if I had stared at this piece code a few times before!

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

2021-03-03 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: nathanchance, nickdesaulniers. Herald added subscribers: jansvoboda11, dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And add tests: when both --prefix(-B) and --gcc-too