[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc92ec0dd92ba: [Matrix] Add support for matrix-by-scalar division. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/ https://reviews.llvm.org/D97857 _

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn updated this revision to Diff 33. fhahn added a comment. Thank you very much John! I applied your suggestions to the wording and removed the unneeded language feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/ https://revi

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:127 +is only supported for expression ``M1 / S1``, where ``M1`` is of matrix type +and ``S1`` is of a real type. You don't need to be so formal in this paragraph, because you're about to get

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

everton.constantino added inline comments. Comment at: clang/test/CodeGen/matrix-type-operators.c:303 } +// CHECK-LABEL: @divide_double_matrix_scalar_float( fhahn wrote: > everton.constantino wrote: > > Shouldn't a test for half floating point be added here as

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

Gerolf added a comment. Nice! This is a straightforward extension with minor code clean-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/ https://reviews.llvm.org/D97857 ___ cfe-commits mailin

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn added inline comments. Comment at: clang/test/CodeGen/matrix-type-operators.c:303 } +// CHECK-LABEL: @divide_double_matrix_scalar_float( everton.constantino wrote: > Shouldn't a test for half floating point be added here as well? Thanks for taking a loo

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn updated this revision to Diff 329596. fhahn added a comment. rebase & added a matrix_types_scalar_division feature, which allows users to check if the current version of clang is new enough to support it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

everton.constantino added inline comments. Comment at: clang/test/CodeGen/matrix-type-operators.c:303 } +// CHECK-LABEL: @divide_double_matrix_scalar_float( Shouldn't a test for half floating point be added here as well? Repository: rG LLVM Github Monorep

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn created this revision. fhahn added reviewers: anemet, rjmccall, rsmith, Bigcheese. Herald added subscribers: dexonsmith, tschuett. fhahn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This patch extends the matrix spec to allow