This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG561abd83ffec: [WebAssembly] Disable uses of
__clang_call_terminate (authored by aheejin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
aheejin updated this revision to Diff 328116.
aheejin added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97834/new/
https://reviews.llvm.org/D97834
Files:
clang/lib/CodeGen/CGException.cpp
clang/lib/CodeGen/Itanium
dschuff accepted this revision.
dschuff added a comment.
I agree this is a good approach, and I also like that it's smaller and simpler.
In the future we can revisit whether following this particular Itanium
convention buys us anything useful or not.
Repository:
rG LLVM Github Monorepo
CHAN
tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.
Nice, this actually looks like a good simplification in addition to fixing the
specific problem.
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4650
+ // Itanium ABI cal
aheejin created this revision.
aheejin added reviewers: dschuff, tlively.
Herald added subscribers: wingo, ecnelises, sunfish, hiraditya,
jgravelle-google, sbc100, mgorny.
aheejin requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-com
