This revision was automatically updated to reflect the committed changes.
Closed by commit rG289fee4ab762: [clangd] Show hex value of numeric constants
(authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D97226?vs=325807&id=327450#toc
Repository:
rG LLVM Github Monorep
kadircet accepted this revision.
kadircet added a comment.
still lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97226/new/
https://reviews.llvm.org/D97226
___
cfe-commits mailing list
cfe-commits@lis
sammccall updated this revision to Diff 325807.
sammccall added a comment.
Add tests
Print negative values too, sign-extended to 32/64 bits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97226/new/
https://reviews.llvm.org/D97226
Files:
clang-too
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
should we also have some tests for a negative value in hover?
Comment at: clang-tools-extra/clangd/Hover.cpp:384
if (ECD->getInitVal() == Val)
-
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Don't show negative numbers
Don't show nu
