njames93 updated this revision to Diff 328134.
njames93 added a comment.
Rename mode to self contained diags.
Added support for modernize-loop-convert. Currently transforming a loop will
prevent any nested loops being transformed if they are affected by the first
transformation. This is counter
steveire added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:516
+ /// applied at a time.
+ bool isSingleFixMode() const { return Context->isSingleFixMode(); }
};
I find the naming of this as "single fix" confusing.
Something alon
njames93 updated this revision to Diff 325622.
njames93 added a comment.
Add include insertion test for clangd showing it attaching the include for
multiple warnings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97121/new/
https://reviews.llvm.or
njames93 updated this revision to Diff 325608.
njames93 marked 2 inline comments as done.
njames93 added a comment.
Add test cases to clangd showing the improved behaviour of fix-its.
Rebased.
Update some comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
steveire added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/IncludeInserter.cpp:81
+if (InsertedHeaders[FileID].contains(Header))
+ return llvm::None;
+ } else if (!InsertedHeaders[FileID].insert(Header).second)
njames93 wrote:
> stev
njames93 added inline comments.
Comment at: clang-tools-extra/clang-tidy/utils/IncludeInserter.cpp:81
+if (InsertedHeaders[FileID].contains(Header))
+ return llvm::None;
+ } else if (!InsertedHeaders[FileID].insert(Header).second)
steveire wrote:
> The
steveire added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:514
const LangOptions &getLangOpts() const { return Context->getLangOpts(); }
+ /// Returns true when the check is ran in a use case when only 1 fix will be
+ /// applied at a time.
---
steveire added a comment.
I just tried to apply this, but I think it conflicts with your other change to
`PreferMemberInitializerCheck.cpp`. Please rebase it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97121/new/
https://reviews.llvm.org/D97121
njames93 created this revision.
njames93 added reviewers: aaron.ballman, steveire.
Herald added subscribers: usaxena95, kadircet, arphaman, kbarton, xazax.hun,
nemanjai.
njames93 updated this revision to Diff 325234.
njames93 added a comment.
njames93 updated this revision to Diff 325238.
njames93
